From owner-freebsd-bugs@FreeBSD.ORG Thu Dec 2 15:30:15 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3A7D1065675 for ; Thu, 2 Dec 2010 15:30:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 61DF58FC0A for ; Thu, 2 Dec 2010 15:30:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oB2FUFul034965 for ; Thu, 2 Dec 2010 15:30:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oB2FUFPM034960; Thu, 2 Dec 2010 15:30:15 GMT (envelope-from gnats) Resent-Date: Thu, 2 Dec 2010 15:30:15 GMT Resent-Message-Id: <201012021530.oB2FUFPM034960@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Anton Yuzhaninov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D075C10656A4 for ; Thu, 2 Dec 2010 15:29:49 +0000 (UTC) (envelope-from citrin@citrin.ru) Received: from mail.vega.ru (mail.vega.ru [90.156.167.5]) by mx1.freebsd.org (Postfix) with ESMTP id 847758FC15 for ; Thu, 2 Dec 2010 15:29:49 +0000 (UTC) Received: from monitoring.int.vega.ru ([10.25.1.153]) by mail.vega.ru with esmtps (TLSv1:AES256-SHA:256) (Exim 4.72 (FreeBSD)) (envelope-from ) id 1POB6R-000G1I-CZ for FreeBSD-gnats-submit@freebsd.org; Thu, 02 Dec 2010 18:29:47 +0300 Received: from monitoring.int.vega.ru (monitoring.int.vega.ru [10.25.1.153]) by monitoring.int.vega.ru (8.14.4/8.14.4) with ESMTP id oB2FTlCD065858 for ; Thu, 2 Dec 2010 15:29:47 GMT (envelope-from citrin@citrin.ru) Received: (from ayuzhaninov@localhost) by monitoring.int.vega.ru (8.14.4/8.14.4/Submit) id oB2FTlx9065857; Thu, 2 Dec 2010 15:29:47 GMT (envelope-from citrin@citrin.ru) Message-Id: <201012021529.oB2FTlx9065857@monitoring.int.vega.ru> Date: Thu, 2 Dec 2010 15:29:47 GMT From: Anton Yuzhaninov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/152781: [patch] decode semget(2) flags in kdump(1) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Anton Yuzhaninov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2010 15:30:15 -0000 >Number: 152781 >Category: kern >Synopsis: [patch] decode semget(2) flags in kdump(1) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 02 15:30:14 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Anton Yuzhaninov >Release: FreeBSD 9.0-CURRENT i386 >Organization: Openstat.ru >Environment: System: FreeBSD citrin.office.vega.ru 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r215543M: Mon Nov 22 19:38:30 MSK 2010 root@citrin.office.vega.ru:/usr/obj/usr/src/sys/NK i386 >Description: kdump(1) decode falgs in syscalls aguments, but decode not all semget(2) flags. >How-To-Repeat: 1. Run code semget(IPC_PRIVATE, 3, IPC_CREAT | IPC_EXCL | SEM_R | SEM_A); semget(IPC_PRIVATE, 3, SEM_R | SEM_A); under ktrace(1) 2. > kdump -n | fgrep semget 87823 a.out CALL semget(0,0x3,0x780) 87823 a.out RET semget 0x60000 87823 a.out CALL semget(0,0x3,0x180) 87823 a.out RET semget 0x30001 kdump -n show 2 semget(2) syscall with differend flags, all right. > kdump | fgrep semget 87823 a.out CALL semget(0,0x3,SEM_R|SEM_A) 87823 a.out RET semget 393216/0x60000 87823 a.out CALL semget(0,0x3,SEM_R|SEM_A) 87823 a.out RET semget 196609/0x30001 Whitout -n same flags shown - it is a bug. Whith attached path correct flags shown: > kdump | fgrep semget 87823 a.out CALL semget(0,0x3,IPC_CREAT|IPC_EXCL|SEM_R|SEM_A) 87823 a.out RET semget 393216/0x60000 87823 a.out CALL semget(0,0x3,SEM_R|SEM_A) 87823 a.out RET semget 196609/0x30001 >Fix: --- mksubr.patch begins here --- Index: usr.bin/kdump/mksubr =================================================================== --- usr.bin/kdump/mksubr (revision 216121) +++ usr.bin/kdump/mksubr (working copy) @@ -254,6 +254,8 @@ void semgetname (int flag) { int or = 0; + if_print_or(flag, IPC_CREAT, or); + if_print_or(flag, IPC_EXCL, or); if_print_or(flag, SEM_R, or); if_print_or(flag, SEM_A, or); if_print_or(flag, (SEM_R>>3), or); --- mksubr.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: