Date: Thu, 30 Aug 2012 09:36:34 +0200 From: Pietro Cerutti <gahr@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/171158: [patch] editors/vim -- remove limitation on unthreaded version of Tcl Message-ID: <20120830073634.GF64517@gahrfit.gahr.ch> In-Reply-To: <20120829222138.GA11490@dragon.NUXI.org> References: <201208291020.q7TAKETL048000@freefall.freebsd.org> <20120829222138.GA11490@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--fKtH0JUtvN5p2ETH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Aug-29, 15:21, David O'Brien wrote: > Hi Pietro, >=20 > > .if defined(WITH_TCL) > > USE_TCL=3D 82+ > > -USE_TCL_NO_THREADS=3D yes > > .endif >=20 > Pietro, > What version of TCL did you test with? (I'm guessing 8.5). Ehm 8.6 actually.. >=20 > The limitation comes from r204122, which re-enabled support for > Tcl versions 8.0, 8.2, 8.3, 8.4, 8.5 (after being disabled by Kris > in r179352). At the time Vim was version 7.1 PL-175. > We've since removed Tcl 8.0 support from ports. >=20 > I'd really rather not have to test the full matrix of all the TCL > versions... I wonder if this isn't what we should commit: >=20 > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile (revision 302880) > +++ Makefile (working copy) > @@ -90,4 +90,3 @@ MAKE_ARGS+=3D CONF_OPT_RUBY=3D"--enable-ruby > .if defined(WITH_TCL) > -USE_TCL=3D 82+ > -USE_TCL_NO_THREADS=3D yes > +USE_TCL=3D 85+ > .endif I would be more than happy to see this committed. Tcl version can cohexist, and < 8.4 exist just to support a couple of legacy softwares. It wouldn't hurt anybody to require >=3D 8.5 to run the interp in vim. --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --fKtH0JUtvN5p2ETH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlA/GAEACgkQwMJqmJVx946KNACfcJq4J6qPIBM/4mFzSTmiAbGr GHoAoMfIUNqCoz9Z8o9Chivrk5qCZcy3 =M2uq -----END PGP SIGNATURE----- --fKtH0JUtvN5p2ETH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120830073634.GF64517>