From owner-svn-ports-head@FreeBSD.ORG  Tue Jan 20 08:28:46 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 6CFEE19E; Tue, 20 Jan 2015 08:28:46 +0000 (UTC)
Date: Tue, 20 Jan 2015 08:28:46 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: marino@freebsd.org
Subject: Re: svn commit: r377495 - head/textproc/py-pygments
Message-ID: <20150120082846.GA84520@FreeBSD.org>
References: <201501200412.t0K4CVOj052563@svn.freebsd.org>
 <20150120081220.GB57237@FreeBSD.org> <54BE0F14.5030304@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54BE0F14.5030304@marino.st>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2015 08:28:46 -0000

On Tue, Jan 20, 2015 at 09:17:24AM +0100, John Marino wrote:
> On 1/20/2015 09:12, Alexey Dokuchaev wrote:
> > On Tue, Jan 20, 2015 at 04:12:31AM +0000, Adam Weinberger wrote:
> >> New Revision: 377495
> >> URL: https://svnweb.freebsd.org/changeset/ports/377495
> >> QAT: https://qat.redports.org/buildarchive/r377495/
> >>
> >> Log:
> >>   Update to 2.0.1.
> >>   
> >>   [...]
> >> -OPTIONS_DEFINE=	DOCS
> >> -
> > 
> > Commit log does not mention this change, was it intended?  If so, what
> > was the reason behind it?
> 
> The line is redundant -- it's presence or absence doesn't change
> anything.

In this case it would be nice to mention something like "remove DOCS option
because the port no longer installs documentation" in the log.

> You know how I write commit messages and thus know I agree it
> could have been mentioned given how short the message was (if it were 1
> of 100 changes I wouldn't have mentioned it myself).

Yes, I know.

./danfe