From owner-freebsd-bugs@FreeBSD.ORG  Thu Jan 28 22:00:22 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3089810656C6
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 28 Jan 2010 22:00:22 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 626CB8FC15
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 28 Jan 2010 22:00:21 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0SM0L56092684
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 28 Jan 2010 22:00:21 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0SM0LAM092683;
	Thu, 28 Jan 2010 22:00:21 GMT (envelope-from gnats)
Date: Thu, 28 Jan 2010 22:00:21 GMT
Message-Id: <201001282200.o0SM0LAM092683@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Efstratios Karatzas <gpf.kira@gmail.com>
Cc: 
Subject: Re: bin/133979: pkg_create(1): pkg_create -n gives an error
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Efstratios Karatzas <gpf.kira@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2010 22:00:22 -0000

The following reply was made to PR bin/133979; it has been noted by GNATS.

From: Efstratios Karatzas <gpf.kira@gmail.com>
To: bug-followup@freebsd.org, randy.belk@gmail.com
Cc:  
Subject: Re: bin/133979: pkg_create(1): pkg_create -n gives an error
Date: Thu, 28 Jan 2010 23:59:16 +0200

 Helloo!
 
 I've done some digging and I think I can provide some feedback.
 The PR originator states that the option "-n" is not coded. This does not
 apply to modern versions of pkg_create.
 
 First of all, take a look at this file: src/usr.sbin/pkg_install/create/main.c
 
 http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/pkg_install/create/main.c?rev=1.36.2.7
 
 You can see that if the "-n" option is supplied, we change the value
 of a global variable
 
 case 'n':
 	    Regenerate = FALSE;
 	    break;
 
 
 Now take a look at this file: src/usr.sbin/pkg_install/create/perform.c
 
 http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/pkg_install/create/perform.c?rev=1.80.2.5
 
 goto function make_dist() and take a look at this:
 
     /*
      * If the package tarball exists already, and we are running in `no
      * clobber' mode, skip this package.
      */
     if (stat(tball, &sb) == 0 && Regenerate == FALSE) {
 	if (Verbose)
 	    printf("Skipping package '%s'.  It already exists.\n", tball);
 	return;
     }
 
 Which does just what the man page says it does.
 Since this behavior cannot be recreated in recent versions, I believe
 the state of
 the PR should change to closed or at least to feedback.
 
 Cheers
 
 -- 
 
 Efstratios "GPF" Karatzas