From owner-cvs-all Tue Mar 6 9:27:37 2001 Delivered-To: cvs-all@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id AF1AD37B719; Tue, 6 Mar 2001 09:27:25 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f26HRMd01341; Tue, 6 Mar 2001 10:27:22 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200103061727.f26HRMd01341@harmony.village.org> To: Dag-Erling Smorgrav Subject: Re: cvs commit: src/sys/modules/ed Makefile src/sys/dev/ed if_ed.cif_ed_pccard.c if_ed_pci.c if_edreg.h if_edvar.h src/sys/i386/confGENERIC NEWCARD Cc: Maxim Sobolev , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "06 Mar 2001 18:25:08 +0100." References: <200103030831.f238VcG09263@freefall.freebsd.org> <3AA4C637.D777CB97@FreeBSD.org> <200103061713.f26HDEd01173@harmony.village.org> Date: Tue, 06 Mar 2001 10:27:22 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message Dag-Erling Smorgrav writes: : root@des /sys/compile/DES# kldload if_ed : kldload: can't load if_ed: Exec format error : root@des /sys/compile/DES# dmesg | tail -1 : link_elf: symbol pccard_product_lookup undefined : : (and yes, I'm positive my kernel and modules are in sync and built : from clean, unmodified sources) That's a simple bug to fix. I'll go fix it right now. pccard is supposed to be such that for both OLDCARD and NEWCARD the modules load as well as the "NOCARD" case. The two pccard_compat_ symbols that are now defined are easy to get rid of (since they should be the card version anyway). The pccard_product_lookup symbol really can and should be inlined (it is small, and the space savings is minimal). Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message