From owner-cvs-all@FreeBSD.ORG Thu Aug 11 12:42:26 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 60B45106564A; Thu, 11 Aug 2011 12:42:26 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f172.google.com (mail-iy0-f172.google.com [209.85.210.172]) by mx1.freebsd.org (Postfix) with ESMTP id D8B928FC19; Thu, 11 Aug 2011 12:42:25 +0000 (UTC) Received: by iye7 with SMTP id 7so3361475iye.17 for ; Thu, 11 Aug 2011 05:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=la1KtZbNFLDjEcNZQITgJn1M9X+dN9GLajUOOWxx6ao=; b=csWSScclQakBbb0Kxf9nYz8rp+QX3nMGb9Wa4ckgh5DwI8z3+b/yENHXffcQbvmRHV SekoBcOHQ37IXo+V+KVuT33TBIMnQy24n4C7YT8sLQVF6Vo4j3UeDLEixYF47db1fRE3 79gEcGFGW6fY5CAp8Wz5uhDDRu1SxrK0RH/TU= Received: by 10.231.25.217 with SMTP id a25mr12418160ibc.52.1313066545116; Thu, 11 Aug 2011 05:42:25 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.191.77 with HTTP; Thu, 11 Aug 2011 05:41:55 -0700 (PDT) In-Reply-To: References: <201108091348.p79DmYFa095351@repoman.freebsd.org> <20110809135332.GA52137@over-yonder.net> <4E418DC6.7040708@FreeBSD.org> From: Chris Rees Date: Thu, 11 Aug 2011 13:41:55 +0100 X-Google-Sender-Auth: Xwo4rUKwrCNwttP2sqNxextQXp4 Message-ID: To: bf1783@gmail.com, Renato Botelho Content-Type: text/plain; charset=ISO-8859-1 Cc: Doug Barton , cvs-all@freebsd.org, ports-committers@freebsd.org, Steven Kreuzer , "Matthew D. Fuller" , cvs-ports@freebsd.org Subject: Re: cvs commit: ports/textproc Makefile ports/textproc/ack Makefile distinfo pkg-descr pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2011 12:42:26 -0000 On 10 August 2011 15:36, b. f. wrote: > On 8/10/11, b. f. wrote: >> On 8/9/11, Chris Rees wrote: >> ... >>>>> Would anyone object if I looked at adding danfe's grep suggestion to >>>>> addport ? We have similar checks in rmport... >> >> No, provided that we can tell addport to skip the check -- I prefer to >> look for matching distfiles and similar portnames or pkg-descr myself, >> in a separate step, and I don't want to have to do it again. > > A separate step, that is, _before_ I've gone to the trouble of > preparing a new port ... > Certainly, so I also put in a new option -y. Renato, does the patch at [1] look OK? Sorry if the code is hideous -- if it needs more comments I'm happy to annotate :P I'll also mention that it's very generous in its matching; p5-Mail-SpamAssassin for example would match anything with Mail, mail spamassassin or SpamAssassin in... Any ideas on how we could make it less general without detracting from it being useful? All segments two characters or fewer are ignored (segments are split by - or _ and short ones are assumed to be country/p5/py etc) and I've also ignored rubygem. Any I've missed? Chris [1] http://people.freebsd.org/~crees/patches/addport-dupecheck.diff