Date: Thu, 11 Aug 2011 13:41:55 +0100 From: Chris Rees <crees@freebsd.org> To: bf1783@gmail.com, Renato Botelho <garga@freebsd.org> Cc: Doug Barton <dougb@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org, Steven Kreuzer <skreuzer@freebsd.org>, "Matthew D. Fuller" <fullermd@over-yonder.net>, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/textproc Makefile ports/textproc/ack Makefile distinfo pkg-descr pkg-plist Message-ID: <CADLo839PYgc4xOVmnuGmQLMM0s5-GcXMv5FJaMK9JOsuWsZQrQ@mail.gmail.com> In-Reply-To: <CAGFTUwMzoke=sN8iwnqY9cocS-Vf9g7_N1GPjdpWtGBDLakCJg@mail.gmail.com> References: <201108091348.p79DmYFa095351@repoman.freebsd.org> <20110809135332.GA52137@over-yonder.net> <DBB34E87-0395-4911-869F-63F857912682@FreeBSD.org> <CADLo83_gNU9CmN8826XokOU8iZcY0E-QG_Q7e%2BNL_1tpT0hZKA@mail.gmail.com> <4E418DC6.7040708@FreeBSD.org> <CADLo83-LBxDk7xVWkCWmAn=Okr8fjgA-VAzocyWNYAW3=-sGdw@mail.gmail.com> <CAGFTUwNPTH0TTtzg8KzGFAUTbCZXqmpoKqAOuRt_yP5_maF70A@mail.gmail.com> <CAGFTUwMzoke=sN8iwnqY9cocS-Vf9g7_N1GPjdpWtGBDLakCJg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 August 2011 15:36, b. f. <bf1783@googlemail.com> wrote: > On 8/10/11, b. f. <bf1783@googlemail.com> wrote: >> On 8/9/11, Chris Rees <crees@freebsd.org> wrote: >> ... >>>>> Would anyone object if I looked at adding danfe's grep suggestion to >>>>> addport ? We have similar checks in rmport... >> >> No, provided that we can tell addport to skip the check -- I prefer to >> look for matching distfiles and similar portnames or pkg-descr myself, >> in a separate step, and I don't want to have to do it again. > > A separate step, that is, _before_ I've gone to the trouble of > preparing a new port ... > Certainly, so I also put in a new option -y. Renato, does the patch at [1] look OK? Sorry if the code is hideous -- if it needs more comments I'm happy to annotate :P I'll also mention that it's very generous in its matching; p5-Mail-SpamAssassin for example would match anything with Mail, mail spamassassin or SpamAssassin in... Any ideas on how we could make it less general without detracting from it being useful? All segments two characters or fewer are ignored (segments are split by - or _ and short ones are assumed to be country/p5/py etc) and I've also ignored rubygem. Any I've missed? Chris [1] http://people.freebsd.org/~crees/patches/addport-dupecheck.diff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839PYgc4xOVmnuGmQLMM0s5-GcXMv5FJaMK9JOsuWsZQrQ>