From nobody Wed May 21 17:37:02 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b2dsH1Lqhz5wG11; Wed, 21 May 2025 17:37:07 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b2dsH0dS1z3y7w; Wed, 21 May 2025 17:37:07 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747849027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XdqhlZIs9CPLKMD5+SjnGljdx9FT0FbL4mtwvwJZAOE=; b=xe05ti4V9QIPa0vsLTm5z76I5TcJ8EME9FA5iu7IVQYfYZKmSjo9A1TzRr3+a7j4YtH1va 7G2z0BUtIhAXqgpXO4IZFVIZt2cDzW/r0oB/4Iev7LMHzUPwD724b6pYlqHeVaWAycsS1h AVpRErT8DvHXGdOCP5aK+DkEyMbqKHNW25x5UjsVLInzHxxqY/yLMqY8N4cZh8YJUHsFTa I9DZUL4f7hvv5qlBaLcFSR3QlGV+7uNWSgsMTX7GzbzLGCjy7zG7q2j+gSR43uE03MP2AN MUUN8dk2JEY6tJJQt2NgwbI+64nXwTKpFNz3xKxRlUq2TVGO2ptW88gs6q5wsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747849027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XdqhlZIs9CPLKMD5+SjnGljdx9FT0FbL4mtwvwJZAOE=; b=n2Xr6XCfuCeZ3Vzfr9DR6GZ+S1NL6RSXSErFwQNv7baEJEfz+nye7Xm+k2VD73LcBJq1oz mYa1CUEYn1wDPoe+8sRTwZGPL/6xlSkFL2bdCfOZl+KyR6dsqrTwoOjuI8x+p6hkRarr8J GICMNTRwp5trKU2r7deZA1fi8wymz5UwKNsRL1PGW3O4o60jQukuoVYWK2gB124i+liRme FPpgMLuJ/1Pf3xv1lvL2vNWI/EC5gj9DV11mqfeYkBDbDPknBAqLb23bH3PRQMNKFv9WXa 1F1RfffgBwE7M7dNZfYa4SbDCU1twpsbJG/6vIVgbUmIz3QjWfJeFr4WRAcrQA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747849027; a=rsa-sha256; cv=none; b=ZOEgaHdehgTvpzBR4uEcxXiJtgcq7IdXsHnXcg+/tMsSkjd+wHfaucwe7m2TuSTM4s3f78 LxnLDWd443E4VWSzRrqZmXDYBZIEWdOt+e9VikFhr6/ePelWtsixujFHzjst1YzuUNem0t Hdh7goRFAwJQaI1N/ZsN/ADz5D94eVEApSKCTEx1mZuOMPDLXhzLF2hfQNo2jv9XqEqMty BCPLQTJ1etc6LgZiRCxS32Xujd/nlmgQ8jkSwPSyVdim3ZZFi6OzhSTwIRqbY5eZEk1epH 6/6+WF0s1p+3qna5FuJGo3UD539nFXhgvUSRblmW0TAxt9YzsmHZ5wYmRsE/TA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2804:f1c:3c:b01:cd55:904c:d339:c978] (unknown [IPv6:2804:f1c:3c:b01:cd55:904c:d339:c978]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4b2dsF38xZz9VP; Wed, 21 May 2025 17:37:05 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: Date: Wed, 21 May 2025 14:37:02 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 3bcf8e6db8e9 - main - loader: loader can pick too large font (check if one side is larger) From: Renato Botelho To: Toomas Soome , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202505130746.54D7khTN010139__37381.4146196068$1747122471$gmane$org@gitrepo.freebsd.org> <692b5cb8-be2e-4197-abec-d8889712f2a8__49356.5424041421$1747847616$gmane$org@FreeBSD.org> Content-Language: en-US Autocrypt: addr=garga@FreeBSD.org; keydata= xsBNBGStavwBCACjNlp/9+Y+VFe9ieR2h/WWbdvjz4Mb2z/f22bGoaskzCfvVNbo/v3i34I9 H6OdgZkGqheQEAD2jNfRbmPr4z40xDMUpYGLds+1Mvg7G3Hms3j5Ef8KaLSWUNWIfwKdfSVR Qs35ccSJxAdRW5YdI6J3xZgika+3Bc4eJ05YE/nWW+PNTYevt5rqD50N3zybVYIcLoqVPpBi AZE/sf5SLiLACIJb1t/s4x+pi8vgWevxVVT9u8V1f8zYErmHSLSqjxii0B3eRZphX9NCJOv9 +tfFZhnENInhn9gT7H4e2YumUltEy3jacONHJF3CC1pvvWEa6lEyypclMOkHQwNON7DLABEB AAHNLFJlbmF0byBCb3RlbGhvIChGcmVlQlNEKSA8Z2FyZ2FARnJlZUJTRC5vcmc+wsCXBBMB CgBBAhsDBQkFo5qABQsJCAcDBRUKCQgLBRYDAgEAAh4FAheAFiEERL7Dxegbnh7xTiQ5Ob6P xxJcZXoFAmSta78CGQEACgkQOb6PxxJcZXrYlggAgaZmr6c1yIWzN8VksHrHpwt/uxONEP+h ljy3yfrMsgfS5wx5Uzgfih1xYZUFC6jiI63CetqBqJpp3g1klRS1UWYKx2NeXphDMYZEdPm/ a6sXh4bKZbk6IE8Yn0/YiRT57d9DtbvswC7Gn7Igj/MSbhl49TvTGyvuB6juaffVoYZViomx 5zMoee8Ml2o2qj3MrCJ+/K8GU54RlpOGqGRsqdwVdr9XEWub6fF2YFwR46cjmbiU3P5urFHH nkJlBGPIwKxHimTW0lZsdx9aCKRDd/D80/WOEzXmk3k8B9lv/GsvOluHmveLhJG1R1tIJ31I f2q8dfTvqsQXnu8CcWRcgc7ATQRkrWr8AQgA1DufoxScA+CWQbUR6zExIu8wXQKrhuRt4DG2 BgynT7EMUvEBadcbQRZXsBpemNfncc9Axyut/+rWiyKJf9BLQuo/9QYmSRvW1U6+0LJUYmdg kMyBeYaPk+vnssv/u9jLuvV7FVgyE0yk1iaWIKOVDD+XrQCOvGw9uSceBrQyCyo3A/eRM/+p vnDCaywR63PKE+3axk6lfNdGK3TnaWmS30/ZDCZlNsXuqprqR4JdT5wXids5o36dsuJ5EZ20 s5hNMD34s4Yr1Y1R9elH6qBsFCpozs0+jwrArxq+UJJCR6hH5W8ZEwJtRC8tzR8mRE1WywzX BXYj0YhfGztQIxZckQARAQABwsB8BBgBCgAmFiEERL7Dxegbnh7xTiQ5Ob6PxxJcZXoFAmSt avwCGwwFCQWjmoAACgkQOb6PxxJcZXr1vgf/SKXhoZcUU5I7TqcbHg0lJz9tICTupCGHWr/s SQgjh9oEM5j1wqW7FlCGP90Tl9K0g3ow9YdbhU7VK470o6pymX9V9eLHzGgkZO/KMEtGBeK1 u+5ePjCJ/MK5B21KODLSU7WrIL1VN5ceXfQPLYt02LMLtPri+oduHD6RNBeA7US1DUzleq5F 9NHGbvV2U7BdDUezpiO8NaFjFZVB11I5d99FxUM5XGVstI3VhsRKZxjY0KnqJzaQgTFsPGmv AUfZVIN1pXgXiedhPXpr8+Y64jP+pHVwpVmh1zYWL6+q3kqFOUVP6c5iiMeoEXZvgJz7x/AC ek3X5gvu8Hpcv+MZIg== In-Reply-To: <692b5cb8-be2e-4197-abec-d8889712f2a8__49356.5424041421$1747847616$gmane$org@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/05/25 14:13, Renato Botelho wrote: > On 13/05/25 04:46, Toomas Soome wrote: >> The branch main has been updated by tsoome: >> >> URL: https://cgit.FreeBSD.org/src/commit/? >> id=3bcf8e6db8e9b30af0a1d445e6e413a332066434 >> >> commit 3bcf8e6db8e9b30af0a1d445e6e413a332066434 >> Author:     Toomas Soome >> AuthorDate: 2025-05-13 07:40:39 +0000 >> Commit:     Toomas Soome >> CommitDate: 2025-05-13 07:44:35 +0000 >> >>      loader: loader can pick too large font (check if one side is larger) >>      The 5e25f7b09977 still allows one side to be too large, fix it. >> --- >>   stand/common/gfx_fb.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/stand/common/gfx_fb.c b/stand/common/gfx_fb.c >> index ad38a657e233..af72ab1a4c99 100644 >> --- a/stand/common/gfx_fb.c >> +++ b/stand/common/gfx_fb.c >> @@ -2082,7 +2082,7 @@ gfx_get_font(teken_unit_t rows, teken_unit_t >> cols, teken_unit_t height, >>            * Skip too large fonts. >>            */ >>           font = fl->font_data; >> -        if (height / font->vfbd_height < rows && >> +        if (height / font->vfbd_height < rows || >>               width / font->vfbd_width < cols) >>               continue; > I still got huge fonts if I remove screen.font from loader.conf.  What > kind of data you want me to collect from my system to help you to get it > fixed? > My upgrade script had a reverse logic and didn't update loader.efi. It's working as expected. Thank you! -- Renato Botelho