From owner-cvs-src@FreeBSD.ORG Fri Sep 16 12:37:31 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 416F016A41F; Fri, 16 Sep 2005 12:37:31 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6730A43D69; Fri, 16 Sep 2005 12:37:21 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j8GCbBAg077938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 16 Sep 2005 16:37:11 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j8GCbAvO077937; Fri, 16 Sep 2005 16:37:10 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 16 Sep 2005 16:37:10 +0400 From: Gleb Smirnoff To: Yar Tikhiy Message-ID: <20050916123710.GX53891@cell.sick.ru> References: <200509161144.j8GBihiM082730@repoman.freebsd.org> <20050916115312.GT53891@cell.sick.ru> <20050916123421.GB23109@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20050916123421.GB23109@comp.chem.msu.su> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2005 12:37:31 -0000 On Fri, Sep 16, 2005 at 04:34:21PM +0400, Yar Tikhiy wrote: Y> On Fri, Sep 16, 2005 at 03:53:12PM +0400, Gleb Smirnoff wrote: Y> > On Fri, Sep 16, 2005 at 11:44:43AM +0000, Yar Tikhiy wrote: Y> > Y> yar 2005-09-16 11:44:43 UTC Y> > Y> Y> > Y> FreeBSD src repository Y> > Y> Y> > Y> Modified files: Y> > Y> sys/net if_vlan.c Y> > Y> Log: Y> > Y> Test the new M_VLANTAG packet flag before calling Y> > Y> m_tag_locate(). This adds little overhead of a simple Y> > Y> bitwise operation in case hardware VLAN acceleration Y> > Y> is on, yet saves the more expensive function call if Y> > Y> the acceleration is off. Y> > Y> Y> > Y> Reviewed by: ru, glebius Y> > Y> X-MFC-after: 6.0 Y> > ^^^^^^^^^^^^^^^^^^^ Y> > Why? Y> Y> 'Cause it's more about code consistency than stability, or performance, Y> or features. So I'd rather not bother re@ with this when they are Y> being flooded with really important bugfixes. It shouldn't be the Y> extra m_tag_locate() call that is likely to be a bottleneck in 6.0 ;) Not a bottleneck, but a significant processing addon for every inbound packet. If you don't mind I will request MFC from re@ after some testing. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE