From owner-svn-src-head@FreeBSD.ORG Fri May 15 21:34:58 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7AEF81065670; Fri, 15 May 2009 21:34:58 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 6A43C8FC0A; Fri, 15 May 2009 21:34:58 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n4FLYwZt035342; Fri, 15 May 2009 21:34:58 GMT (envelope-from des@svn.freebsd.org) Received: (from des@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n4FLYwPq035341; Fri, 15 May 2009 21:34:58 GMT (envelope-from des@svn.freebsd.org) Message-Id: <200905152134.n4FLYwPq035341@svn.freebsd.org> From: Dag-Erling Smorgrav Date: Fri, 15 May 2009 21:34:58 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r192160 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2009 21:34:58 -0000 Author: des Date: Fri May 15 21:34:58 2009 New Revision: 192160 URL: http://svn.freebsd.org/changeset/base/192160 Log: Remove do-nothing code that was required to dirty the old buffer on Alpha. Coverity ID: 838 Approved by: jhb, alc Modified: head/sys/kern/kern_sysctl.c Modified: head/sys/kern/kern_sysctl.c ============================================================================== --- head/sys/kern/kern_sysctl.c Fri May 15 21:12:10 2009 (r192159) +++ head/sys/kern/kern_sysctl.c Fri May 15 21:34:58 2009 (r192160) @@ -1373,8 +1373,7 @@ int sysctl_wire_old_buffer(struct sysctl_req *req, size_t len) { int ret; - size_t i, wiredlen; - char *cp, dummy; + size_t wiredlen; wiredlen = (len > 0 && len < req->oldlen) ? len : req->oldlen; ret = 0; @@ -1387,16 +1386,6 @@ sysctl_wire_old_buffer(struct sysctl_req return (ret); wiredlen = 0; } - /* - * Touch all the wired pages to avoid PTE modified - * bit emulation traps on Alpha while holding locks - * in the sysctl handler. - */ - for (i = (wiredlen + PAGE_SIZE - 1) / PAGE_SIZE, - cp = req->oldptr; i > 0; i--, cp += PAGE_SIZE) { - copyin(cp, &dummy, 1); - copyout(&dummy, cp, 1); - } } req->lock = REQ_WIRED; req->validlen = wiredlen;