From owner-cvs-all Sat Dec 4 22:15:43 1999 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id 5299A14C59; Sat, 4 Dec 1999 22:15:25 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 901071CA0; Sun, 5 Dec 1999 14:14:17 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: Marcel Moolenaar Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/linux linux_ioctl.h imgact_linux.c linux.h linux_ioctl.c linux_sysvec.c linux_util.h In-Reply-To: Message from Marcel Moolenaar of "Sat, 04 Dec 1999 03:10:23 PST." <199912041110.DAA62066@freefall.freebsd.org> Date: Sun, 05 Dec 1999 14:14:17 +0800 From: Peter Wemm Message-Id: <19991205061417.901071CA0@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Marcel Moolenaar wrote: > Log: > Implement pluggable ioctl handlers. [..] > linux.h and linux_ioctl.[ch] have been made to conform to style(9) as > much as possible. [..] > Revision Changes Path > 1.35 +3 -1 src/sys/i386/linux/imgact_linux.c > 1.41 +302 -650 src/sys/i386/linux/linux.h > 1.48 +1343 -1127src/sys/i386/linux/linux_ioctl.c [..] This is a classic example of why *NOT* to do this. The actual change is lost in the noise. It would have been far better to do this as two seperate commits, as it's quite useless like this. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message