From owner-freebsd-current@FreeBSD.ORG Fri Nov 11 05:53:47 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 20754106566B for ; Fri, 11 Nov 2011 05:53:47 +0000 (UTC) (envelope-from ambrosehua@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id AA43B8FC0A for ; Fri, 11 Nov 2011 05:53:46 +0000 (UTC) Received: by faar19 with SMTP id r19so5174596faa.13 for ; Thu, 10 Nov 2011 21:53:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=z7i+j+j5/Uaw7onbKaV6b+lmMECagz7CPpIvB/ICiYE=; b=TDJayu5+uBW4GwCL7YhhTXpGD8s2tPMkcrGT8iJvUTIvxwssP0lc+ke7SyXDxxEUGG RdYwH/e9jm1hCoTcSCvwpsfiZoTjf9EGYLoQRTVCgSJK/dd4Um9F4+ccyURro85ph7TQ 2Dwib82zMElzi6XOf87y+K/BLIgEhEpxb0W5Q= MIME-Version: 1.0 Received: by 10.223.17.23 with SMTP id q23mr16956401faa.11.1320990825447; Thu, 10 Nov 2011 21:53:45 -0800 (PST) Received: by 10.223.116.145 with HTTP; Thu, 10 Nov 2011 21:53:45 -0800 (PST) In-Reply-To: References: Date: Fri, 11 Nov 2011 13:53:45 +0800 Message-ID: From: Paul Ambrose To: Ryan Stone Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current Subject: Re: [PATCH] Fix types of arguments to dtrace syscall return probes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2011 05:53:47 -0000 If there is anything I can do for kern/160307 or other Dtrace issue , please let me know 2011/11/8 Ryan Stone : > On Mon, Nov 7, 2011 at 9:16 AM, Paul Ambrose wrote= : >> diff --git a/sys/kern/kern_ctf.c b/sys/kern/kern_ctf.c >> index bdff96e..2737860 100644 >> --- a/sys/kern/kern_ctf.c >> +++ b/sys/kern/kern_ctf.c >> @@ -90,7 +90,7 @@ link_elf_ctf_get(linker_file_t lf, linker_ctf_t *lc) >> =A0 =A0 =A0 =A0 * ctfcnt to -1. See below. >> =A0 =A0 =A0 =A0 */ >> =A0 =A0 =A0 =A0if (ef->ctfcnt < 0) >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 return (0); >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 return (EFTYPE); >> >> =A0 =A0 =A0 =A0/* Now check if we've already loaded the CTF data.. */ >> =A0 =A0 =A0 =A0if (ef->ctfcnt > 0) { >> ------------------------------------------------------------------------= --------------- > > I have committed this as r227342. =A0Thanks for the fix. > >> And I post another fix for the ${NORMAL_CTFCONVERT} issue, could you >> check it for me? > > Yes, I can take a look. > >> =A0kern/160307, I check the /boot/kernel/kernel with ctfdump, and found >> the kernel image has right ctf information, do you >> have any idea? > > Offhand, no. =A0I'll try to find some time to look at your PRs. >