From owner-svn-ports-all@FreeBSD.ORG Tue Jun 4 05:36:28 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 5CB7DBDB; Tue, 4 Jun 2013 05:36:28 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-x229.google.com (mail-wg0-x229.google.com [IPv6:2a00:1450:400c:c00::229]) by mx1.freebsd.org (Postfix) with ESMTP id 4654D1C47; Tue, 4 Jun 2013 05:36:27 +0000 (UTC) Received: by mail-wg0-f41.google.com with SMTP id k13so3388398wgh.2 for ; Mon, 03 Jun 2013 22:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=tnI3/A6HDWrMGSFszZ0Gb8hdG5VhsVYgUV9cbYQtFjw=; b=A0FHozI2xeh10sqQkWqmEBaN5ZeTKr1OdJDpXbIsW6Kb0BVOpySXb78dHXcxacYRZo lVPbr/vvn0kncIJ0yHTo4LWhFICWqV1kf99BmzUOW7quepjZhI6g82h5QTI8uI5zb7DP 1pRdvAKqpKPCUiQSXNea80zyfMgnucefM7Bk5kWojr/cwAeziPZBckN73mP6k60butLf XlaS2NlPGa0wJlCec5JYw3NuxK4M/PEf1EHDKNmnJRxju3H9GvM/8asPND+SD/+djaa5 OMs03F+M2bXh+cfU0Gd56nF6ci5T0FVIr5UZuHOop6xsEvG2Yc4kqXczpgbeS+Lmqh4K iF8A== X-Received: by 10.180.183.206 with SMTP id eo14mr1062216wic.36.1370324186290; Mon, 03 Jun 2013 22:36:26 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id fx7sm126744wic.11.2013.06.03.22.36.24 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 03 Jun 2013 22:36:25 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 4 Jun 2013 07:36:22 +0200 From: Baptiste Daroussin To: Tom Rhodes Subject: Re: svn commit: r319792 - head/sysutils/fsc Message-ID: <20130604053622.GA94820@ithaqua.etoilebsd.net> References: <201306031632.r53GWPdP069628@svn.freebsd.org> <51ACC994.4060608@FreeBSD.org> <20130603133012.114c2ae7.trhodes@FreeBSD.org> <51ACDC95.4060600@FreeBSD.org> <20130603155106.7f3e5826.trhodes@FreeBSD.org> <20130603201831.GO12427@ithaqua.etoilebsd.net> <20130603180413.7fbe7366.trhodes@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: <20130603180413.7fbe7366.trhodes@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, bdrewery@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2013 05:36:28 -0000 --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 03, 2013 at 06:04:13PM -0400, Tom Rhodes wrote: > On Mon, 3 Jun 2013 22:18:31 +0200 > Baptiste Daroussin wrote: >=20 > > On Mon, Jun 03, 2013 at 03:51:06PM -0400, Tom Rhodes wrote: > > > On Mon, 03 Jun 2013 13:12:37 -0500 > > > Bryan Drewery wrote: > > >=20 > > > > On 6/3/2013 12:30 PM, Tom Rhodes wrote: > > > > > On Mon, 03 Jun 2013 11:51:32 -0500 > > > > > Bryan Drewery wrote: > > > > >=20 > > > > >> This is bad form. If you are changing upstream code it should be= a new > > > > >> release version, not a reroll. We frequently have problems with = other > > > > >> upstreams doing this and should follow our own guidelines. > > > > >=20 > > > > > I'm not bumping the version used for a simple gcc->clang warning > > > > > fix. That's why I just bumped PORTVERSION. If we want to do a > > > > > new version, I'll get ahold of the NetBSD people, who also work > > > > > with keeping a port, and discuss doing that. In this case, it > > > > > was a simple fix rather than adding a 2 line patch to a files/ > > > > > directory. > > > > >=20 > > > >=20 > > > > The proper way to do is this a new release, or a patch in files wit= h a > > > > PORTREVISION, or a sed in post-patch. This is the convention. Rerol= ling > > > > upstream is a big no no. Rerolling is obscure and very frowned upon. > > > > This also impacts NetBSD if they are tracking checksums, and any ot= her > > > > projects depending on the checksum of the upstream tarball. > > >=20 > > > I'll look at bumping the release version - there are some other > > > changes that need made anyway, I just wanted to fix the build so > > > users could build it again. > >=20 > > In that case a patch in files/ is the way to go. >=20 > I think the changes are a version bump - I'm working with some > NetBSD people on this, so I'll discuss with them. >=20 This right statement should have been to not reroll the distfile but rather= to put a patch in files/ and bump portrevision. regards, Bapt --wac7ysb48OaltWcw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGtfNYACgkQ8kTtMUmk6EwuGQCgvhHjHxagpX63nLALs7SaflJf fYEAn3NWJh9C5ExlJmf9ff4Xbd6A+XCN =1VMp -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--