From owner-cvs-usrsbin Fri Jan 3 02:52:59 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id CAA12848 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 02:52:59 -0800 (PST) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id CAA12677; Fri, 3 Jan 1997 02:51:32 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id LAA27016; Fri, 3 Jan 1997 11:51:24 +0100 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id LAA04569; Fri, 3 Jan 1997 11:51:23 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.8.4/8.6.9) id LAA14219; Fri, 3 Jan 1997 11:49:03 +0100 (MET) Message-ID: Date: Fri, 3 Jan 1997 11:49:03 +0100 From: j@uriah.heep.sax.de (J Wunsch) To: jkh@freefall.freebsd.org (Jordan K. Hubbard) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c References: <199701030713.XAA04264@freefall.freebsd.org> X-Mailer: Mutt 0.55-PL10 Mime-Version: 1.0 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199701030713.XAA04264@freefall.freebsd.org>; from Jordan K. Hubbard on Jan 2, 1997 23:13:24 -0800 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Jordan K. Hubbard wrote: > jkh 97/01/02 23:13:23 > > Modified: usr.sbin/syslogd syslogd.c > Log: > Unlink LogName before attempting to open it. Since we now have a lovely > bug in syslogd which causes it to die after random amounts of time (widely > reported), this at least allows the administrator to easily restart it > without wondering why it simply exits again each time. This change is wrong. We've been there before, and deliberately decided to keep the unlike out, and leave this to /etc/rc, or to the admin to do it. Right now, you've broken logging from savecore(8) which writes to the syslog socket before syslogd is running. sysylogd used to be able to extract its messages from the socket buffer previously (maybe months ago). Don't work around bugs by introducing new bugs. If syslogd dies, it must be investigated. Mine didn't yet, but i've noticed: Jan 1 16:34:09 uriah syslogd: /dev/: Is a directory Jan 1 16:34:09 uriah last message repeated 3 times ...without knowing what went wrong. Too bad that you've also instantly merged this to 2.2. Changes of this kind should at least be discussed and run in -current for a week or two before. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)