From owner-freebsd-net@FreeBSD.ORG Tue Aug 18 22:55:46 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DE66106568F for ; Tue, 18 Aug 2009 22:55:46 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outX.internet-mail-service.net (outx.internet-mail-service.net [216.240.47.247]) by mx1.freebsd.org (Postfix) with ESMTP id E0AF88FC16 for ; Tue, 18 Aug 2009 22:55:45 +0000 (UTC) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id 68D09B3F80; Tue, 18 Aug 2009 15:55:46 -0700 (PDT) X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id 106742D6011; Tue, 18 Aug 2009 15:55:44 -0700 (PDT) Message-ID: <4A8B316F.3030408@elischer.org> Date: Tue, 18 Aug 2009 15:55:43 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605) MIME-Version: 1.0 To: d@delphij.net References: <527700.21341.qm@web63902.mail.re1.yahoo.com> <4A8B3011.6070104@delphij.net> In-Reply-To: <4A8B3011.6070104@delphij.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: pyunyh@gmail.com, Barney Cordoba , David Christensen , "freebsd-net@freebsd.org" , Jack Vogel , Jack F Vogel , yongari@freebsd.org Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2009 22:55:46 -0000 Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Barney Cordoba wrote: >> --- On Tue, 8/18/09, Pyun YongHyeon wrote: >> >>> From: Pyun YongHyeon >>> Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] >>> To: "Xin LI" >>> Cc: "Barney Cordoba" , "David Christensen" , "d@delphij..net" , "freebsd-net@freebsd.org" , "Jack Vogel" , "Jack F Vogel" , yongari@freebsd.org, "Julian Elischer" >>> Date: Tuesday, August 18, 2009, 5:49 PM >>> On Tue, Aug 18, 2009 at 02:03:37PM >>> -0700, Xin LI wrote: >>>> -----BEGIN PGP SIGNED MESSAGE----- >>>> Hash: SHA1 >>>> >>>> Hi, Jack, >>>> >>>> I have looked into the code history and found that >>> sys/dev/em/if_em.c,v >>>> 1.119 has introduced the arp_ifinit() call in order to >>> fix the problem >>>> that if_em won't send ARP when IP address is changed. >>>> >>>> I think we can further improve it as attached, say, >>> only do it when >>>> IFF_NOARP is not set. This should have no effect >>> for usual >>>> configuration but fix the problem when NOARP is the >>> desired behavior. >>> That change was introduced by me. I guess the root cause of >>> the >>> problem was long initialization time of hardware which in >>> turn >>> resulted in unbearable boot time when multiple-alias >>> addresses are >>> assigned to em(4). I don't remember details,though. >>> >>> Since we're in the release cycle, the change you suggested >>> would be >>> quick fix for 8.0. I think em(4)/igb(4) should remove >>> SIOCSIFADDR >>> handling in driver which is layering violation. >> There are 2 kinds of programmers; those who do things "correctly', >> and those that do things that work. >> >> 99.99999% of the people will be using ARPs, so don't be silly and >> break the driver to solve a case that almost no-one cares about please. > Cisco.Ironport runs 50% (2 out of 4) of their em interfaces in noarp mode. please keep noarp working! > I see no reason how you have reached the "99.99999%" conclusion. My > employer for instance, has several millions of dollars worth of hardware > purchase every year, and, we do care about DSR, or NOARP being working > or not. > > Cheers, > - -- > Xin LI http://www.delphij.net/ > FreeBSD - The Power to Serve! > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.12 (FreeBSD) > > iEYEARECAAYFAkqLMBEACgkQi+vbBBjt66DtJACcCuMIEljhYtKT/B9xP18HYzLD > gMwAmwQpJiVSzFJzgXoNggWdRF/kj2Qs > =ROT8 > -----END PGP SIGNATURE----- > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"