From owner-freebsd-current@freebsd.org Tue Feb 23 17:05:38 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 73B3354ACAE for ; Tue, 23 Feb 2021 17:05:38 +0000 (UTC) (envelope-from tsoome@me.com) Received: from st43p00im-zteg10063401.me.com (st43p00im-zteg10063401.me.com [17.58.63.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DlQRQ2k02z3pxj for ; Tue, 23 Feb 2021 17:05:38 +0000 (UTC) (envelope-from tsoome@me.com) Received: from nazgul.lan (148-52-235-80.sta.estpak.ee [80.235.52.148]) by st43p00im-zteg10063401.me.com (Postfix) with ESMTPSA id 2E5BF4A02E8; Tue, 23 Feb 2021 17:05:29 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: testers needed: loader: use display pixel density for font autoselection From: Toomas Soome In-Reply-To: <59877cd0-781a-4ee9-da3e-8fc80bc92f81@alvermark.net> Date: Tue, 23 Feb 2021 19:05:26 +0200 Cc: FreeBSD Developers , freebsd-current Content-Transfer-Encoding: quoted-printable Message-Id: <30FE8DB4-19C4-4A7E-926C-A790562D09DC@me.com> References: <59877cd0-781a-4ee9-da3e-8fc80bc92f81@alvermark.net> To: Jakob Alvermark X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-02-23_08:2021-02-23, 2021-02-23 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=957 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2102230142 X-Rspamd-Queue-Id: 4DlQRQ2k02z3pxj X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2021 17:05:38 -0000 > On 23. Feb 2021, at 17:53, Jakob Alvermark = wrote: >=20 > On 2/23/21 12:27 PM, Toomas Soome via freebsd-current wrote: >> hi! >>=20 >> I have done some work to make font pickup a bit smarter (hopefully = better;), but my own ability to test is limited to one bugged supermicro = and one MBP with retina display=E2=80=A6 >>=20 >> The phab link ishttps://reviews.freebsd.org/D28849 = >>=20 >> I have built loader binaries as well (bios and uefi): >> loader_lua >> loader_lua.efi >>=20 >> To test, you should remove screen.font=3D line from loader.conf and = test with different resolutions. >>=20 >> thanks, >> toomas >=20 >=20 >=20 > Hi Toomas, >=20 >=20 > I tested on five different setups. >=20 > Surface Pro 10.6"@1920x1080: >=20 > The loader menu looks different, the "FreeBSD" text is on the right = side of the screen. I think, this was the lua script bug we did fix not too long time ago. >=20 > Otherwise, the font size is what I would call a normal size. >=20 >=20 > Acer laptop 11.6"@1366x768: >=20 > Menu looks fine. Almost fills the entire screen. >=20 > The font feels a little too big. The laptop built in displays usually do not give out EDID (we get = physical dimensions from EDID), so there we fall back to try to get = 80x25 terminal method. >=20 >=20 > Thinkpad built in 13"@1920x1080: >=20 > Menu looks fine, but a little slow. >=20 > The font size is a little to big for my liking. When drm loads and = mirrors the screen to my external 27" it looks comically large. >=20 There is another issue - once DRM will kick in, we should re-consider = the console attributes, like fonts, but at this time, the kernel itself = only can use what was built in (8x16), or what loader was offering = (default if present). So it is up to user to act there. >=20 > Thinkpad external 24"@1920x1200: >=20 > Menu looks OK, uses about a quarter of the screen. >=20 > Font size is fine, but once drm loads it looks a bit squeezed (like = thin and tall), but I guess that's drm detecting the built in 1920x1080, = and the external display is stretched. >=20 >=20 > Thinkpad external 27"@3840x2160: >=20 > Menu looks OK, uses about a quarter of the screen. >=20 > Font size is fine. >=20 > Looking at the dmesg though, it says: VT(efifb): resolution 1920x1080 >=20 >=20 > Jakob >=20 Those cases .. I suppose the menu was still at left side, not in middle? = The thing there is, our menu is designed for 80x25 screen, with = respective constants.=20 many thanks for testing, toomas