ts-src-main@freebsd.org
Subject: Re: git: 1c9ff80f0635 - main - tools.build: add sys/cdefs.h to
 SYSINCS, since lots of other headers use it
Message-ID: <aU7Vu_sMM1KTFW8L@kib.kiev.ua>
References: <694ea9cc.9f30.1d45a192@gitrepo.freebsd.org>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
X-BeenThere: dev-commits-src-all@freebsd.org
Sender: owner-dev-commits-src-all@FreeBSD.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <694ea9cc.9f30.1d45a192@gitrepo.freebsd.org>
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
	NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.2
X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Rspamd-Queue-Id: 4ddDqG2LSyz3FWN

On Fri, Dec 26, 2025 at 03:29:16PM +0000, Dimitry Andric wrote:
> The branch main has been updated by dim:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=1c9ff80f06350fa44b7e50ce09ad665ab0082abb
> 
> commit 1c9ff80f06350fa44b7e50ce09ad665ab0082abb
> Author:     Dimitry Andric <dim@FreeBSD.org>
> AuthorDate: 2025-12-26 15:26:13 +0000
> Commit:     Dimitry Andric <dim@FreeBSD.org>
> CommitDate: 2025-12-26 15:26:13 +0000
> 
>     tools.build: add sys/cdefs.h to SYSINCS, since lots of other headers use it
>     
>     This is needed to let the legacy stage compile against newer versions of
>     sys/font.h, which transitively includes sys/cdefs.h, and requires the
>     new __nonstring macro from it.
>     
>     Fixes:          e2c93ed09f25
>     MFC after:      3 days
> ---
>  tools/build/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/build/Makefile b/tools/build/Makefile
> index a701c12a9b5c..2c6237c4dd7d 100644
> --- a/tools/build/Makefile
> +++ b/tools/build/Makefile
> @@ -351,6 +351,10 @@ MSDOSFSINCS+=	${SRCTOP}/sys/fs/msdosfs/fat.h
>  MSDOSFSINCS+=	${SRCTOP}/sys/fs/msdosfs/msdosfsmount.h
>  DISKINCS+=	${SRCTOP}/sys/sys/disk/bsd.h
>  
> +# Needed to build most of the things below, which include sys/cdefs.h either
> +# directly or transitively
> +SYSINCS+=	${SRCTOP}/sys/sys/cdefs.h
> +
>  # Needed to build config (since it uses libnv)
>  SYSINCS+=	${SRCTOP}/sys/sys/_nv.h
>  SYSINCS+=	${SRCTOP}/sys/sys/nv.h ${SRCTOP}/sys/sys/cnv.h \

Then the sys/_visible.h needs to be added as well if it is not added yet.