From nobody Wed Jul 8 05:42:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gw6Rf067Dz6kkXD for ; Wed, 08 Jul 2026 05:42:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gw6Rd6RzLz3wqQ for ; Wed, 08 Jul 2026 05:42:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783489325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nsGhr7Wbvf57woYEHnaAXzdgm+iAKidGWUfHhgLvJO0=; b=vEnjrYZblZeRfe814bnI2EkQGGT9ZSI0MM/FgZGD0t/Kuh+ShJBUwCmuf/Gcvf9FZwHBuU PFY43usxzedPNAf4CaNNBR+GVMzXabUcYCvvynzmTIy6iYitSEfhcGZEhg6NQbrvwSKYqe c2WiudlPD3HV7JJDvbmrm3H22DJ2pDG5ikPgbM9KF9Fv77TbhpJXfjV7m9i/WokKP/6wY6 a3uL/BVjpBuTZBSXrp4AThyMP5UIQnFagLeIEll9ZvrQeOyghG1jmp81ElFKUNmaFrde3h JShlupoYhOTB+YDgiNzn2/SNe3L9hjlwT34gpZSEmfkYm/6g3HIJJ/9jywjOuw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783489325; a=rsa-sha256; cv=none; b=trENRDxvNB6UZY3clS64C050rVs5bbIBEBWWZsyvsXoqvMIrgcG6ErjAhSlYD5WzP3GqXO AoqqKNSqDAR2sHJxHadpfYxsBrDJrvhVmWhrhoKxvrorlEPUcaiTfjlYZ8FNR3JvOhypAZ x7pxpIZHZ7nNMWHUSCOEYk2iZQtaSIftKJKleKpkowQvvmrAaLPNLjZ3FqohXhx8n7V/Vn U3xb+hhUzACZIiNzT6tTqmj3cpkHpe3lr0Z41Z8IBrDF2L3ixkYJEUT0Voh74/WGBvT0JY xgpCLavPUyaU/U899d58WvJ5iam9DNHEaFuqtgTw74scgi4kBMP8IEcL7JO5+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783489325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nsGhr7Wbvf57woYEHnaAXzdgm+iAKidGWUfHhgLvJO0=; b=tTUTtjSDE7Uejjb95ggfSzbEOkIM27WKoRKSlbE5ZyVN6VuSk9F3JYWSkxYJKzAxER2kcK V1DxaH21o8fiq3byNTRI4EMmfyS3J756l9P/wevF7JTHzCHDUyvZ2E9VrB2Ga4NEpaYY66 e5Coz80yIhEyqRIw6k1S34/KY6iZsBU3qe9s7+CiY1tysLf01c9OB+ZaR47A2wDR9yDDI7 yBmUQRysi/nAxUscpgM1pAti00WV9g4nx0p+BrGOc/7U2jZXQuj0ihK8rVjwUXp1mbyqMk BO4TTaUetK7DSOlqSy2hJXDMfW5IMN8YaA6eDK5rX6JKXXJ80y8WZhWVlouk4A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gw6Rd4wqkz17LM for ; Wed, 08 Jul 2026 05:42:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39cb4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 08 Jul 2026 05:42:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih From: Adrian Chadd Subject: git: 4e0fc4d44dc1 - main - fwcam: set ISO speed from device link speed List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4e0fc4d44dc18d0d3fd3d79f9074b068f2ee6eeb Auto-Submitted: auto-generated Date: Wed, 08 Jul 2026 05:42:05 +0000 Message-Id: <6a4de32d.39cb4.7d96b2a7@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=4e0fc4d44dc18d0d3fd3d79f9074b068f2ee6eeb commit 4e0fc4d44dc18d0d3fd3d79f9074b068f2ee6eeb Author: Abdelkader Boudih AuthorDate: 2026-07-08 05:31:22 +0000 Commit: Adrian Chadd CommitDate: 2026-07-08 05:32:44 +0000 fwcam: set ISO speed from device link speed iso_speed was never initialized, defaulting to S100 regardless of the camera's actual link speed. Some cameras firmwares reject ISO_EN when the speed field in the ISO_CHANNEL register does not match their capabilities. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D58091 --- sys/dev/firewire/fwcam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/firewire/fwcam.c b/sys/dev/firewire/fwcam.c index 752558a1ecea..251451bc289e 100644 --- a/sys/dev/firewire/fwcam.c +++ b/sys/dev/firewire/fwcam.c @@ -962,6 +962,7 @@ fwcam_post_explore(void *arg) sc->fwdev = fwdev; sc->cmd_hi = 0xffff; sc->cmd_lo = 0xf0000000 | (cmd_base << 2); + sc->iso_speed = min(fwdev->speed, FWSPD_S400); FWCAM_UNLOCK(sc); err = taskqueue_enqueue(taskqueue_thread,