From owner-freebsd-arch@FreeBSD.ORG Mon Jul 28 15:36:02 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 099A837B401 for ; Mon, 28 Jul 2003 15:36:02 -0700 (PDT) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4435743FBD for ; Mon, 28 Jul 2003 15:36:01 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h6SMZx9t001312; Mon, 28 Jul 2003 18:35:59 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20030728210223.GZ12996@roark.gnf.org> References: <20030725230839.GR12996@roark.gnf.org> <20030728210223.GZ12996@roark.gnf.org> Date: Mon, 28 Jul 2003 18:35:58 -0400 To: Gordon Tetlow From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: arch@freebsd.org Subject: Re: Patch to crunchgen to fix errors using make -P X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jul 2003 22:36:02 -0000 At 2:02 PM -0700 7/28/03, Gordon Tetlow wrote: >On Fri, Jul 25, 2003, Garance A Drosihn wrote: > > >> Following up on what you figured out, I realized that we >> could also fix this by changing the line in >> >> /usr/src/rescue/rescue/Makefile >> >> so it's: >> >> MAKEFLAGS= MAKEOBJDIRPREFIX=${CRUNCHOBJS} crunchgen -q -m ... >> >> A quick test showed that this allowed me to add all the debug >> flags I wanted to add, without having to change crunchgen. > >Good point, but I suppose the real question is whether we want to >fix crunchgen in the general sense -- or just this one instance. >I'm not opposed to either solution. I am playing around with some make options that I *would* want to pass through crunchgen (if I can get them to work right). By having only the change in the rescue/Makefile, it would be easy to get that to happen when I want it to. I don't feel too strongly about it, but this just "feels" more flexible. >If I don't hear anything, I'll commit the Makefile solution and >possibly add a comment to crunchgen warning of the potential >issues from the environment that crunchgen inherits. It would probably be a good idea to put a short paragraph in the 'CAVEATS' section of the man page. Someday maybe we could change crunchgen so it knew what output lines it could ignore, but there's no need to worry about that right now. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu