From owner-svn-src-stable-10@FreeBSD.ORG Tue Feb 4 14:59:16 2014 Return-Path: Delivered-To: svn-src-stable-10@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7BD49C2F; Tue, 4 Feb 2014 14:59:16 +0000 (UTC) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4A14B1647; Tue, 4 Feb 2014 14:59:15 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1WAhSv-0000Rw-45; Tue, 04 Feb 2014 14:59:09 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id s14Ex66p064629; Tue, 4 Feb 2014 07:59:06 -0700 (MST) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/L5x4ubEUtmzO7QV8SRXcj Subject: Re: svn commit: r261455 - in stable/10: lib/libc/sparc64/fpu lib/libc/xdr sys/amd64/pci sys/amd64/vmm/intel sys/arm/arm sys/arm/at91 sys/arm/broadcom/bcm2835 sys/arm/econa sys/arm/freescale/imx sys/arm... From: Ian Lepore To: Eitan Adler In-Reply-To: <201402040336.s143ah3l039786@svn.freebsd.org> References: <201402040336.s143ah3l039786@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Tue, 04 Feb 2014 07:59:06 -0700 Message-ID: <1391525946.13026.106.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-10@FreeBSD.org X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Feb 2014 14:59:16 -0000 On Tue, 2014-02-04 at 03:36 +0000, Eitan Adler wrote: > Author: eadler > Date: Tue Feb 4 03:36:42 2014 > New Revision: 261455 > URL: http://svnweb.freebsd.org/changeset/base/261455 > > Log: > MFC r258779,r258780,r258787,r258822: > > Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this > shifts into the sign bit. Instead use (1U << 31) which gets the > expected result. > > Similar to the (1 << 31) case it is not defined to do (2 << 30). > > This fix is not ideal as it assumes a 32 bit int, but does fix the issue > for most cases. > > A similar change was made in OpenBSD. > This is causing arm breakage, I think r258787 needs to be mfc'd to fix. -- Ian