From owner-freebsd-bugs@FreeBSD.ORG  Mon Oct 15 10:06:23 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0336116A417;
	Mon, 15 Oct 2007 10:06:23 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D442D13C46A;
	Mon, 15 Oct 2007 10:06:22 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from freefall.freebsd.org (kib@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FA6MOJ076677;
	Mon, 15 Oct 2007 10:06:22 GMT
	(envelope-from kib@freefall.freebsd.org)
Received: (from kib@localhost)
	by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9FA6Msh076673;
	Mon, 15 Oct 2007 10:06:22 GMT (envelope-from kib)
Date: Mon, 15 Oct 2007 10:06:22 GMT
Message-Id: <200710151006.l9FA6Msh076673@freefall.freebsd.org>
To: sem@FreeBSD.org, kib@FreeBSD.org, freebsd-bugs@FreeBSD.org
From: kib@FreeBSD.org
Cc: 
Subject: Re: kern/116310: [patch] prevent junk lines in log on SMP
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Oct 2007 10:06:23 -0000

Synopsis: [patch] prevent junk lines in log on SMP

State-Changed-From-To: open->closed
State-Changed-By: kib
State-Changed-When: Mon Oct 15 10:03:57 UTC 2007
State-Changed-Why: 
I think the patch is wrong. You cannot take the (default sleepable) mutex
in the printf path, since the function is called from arbitrary kernel
context. I do not think that even spin mutex could be used there.

The right solution to the problem seems be setting the PRINTF_BUFR_SIZE
kernel config option.

http://www.freebsd.org/cgi/query-pr.cgi?pr=116310