From owner-svn-src-projects@freebsd.org Wed Apr 27 16:55:43 2016 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA5E7B1EA01 for ; Wed, 27 Apr 2016 16:55:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ig0-x234.google.com (mail-ig0-x234.google.com [IPv6:2607:f8b0:4001:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A6EA01A1F for ; Wed, 27 Apr 2016 16:55:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ig0-x234.google.com with SMTP id bi2so133852596igb.0 for ; Wed, 27 Apr 2016 09:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=014EeENY2me/qFzfkddDJOfJfDVf12g0AgfnrXRnuq8=; b=qsMrbqVbH8xa/qGI/rZj9o/4D48tVD8Mz5Mw0alBT04JhQMAkh6/rn1drVg/u0v0cJ EOyIai4HIlJ4KNZyAFt4ZeCH4Qpfu2EDh0bCNXG5SZM8fKQrnHx+XOvrmewBZeRjcELM nCvQWHVgnaR7FeOsBejtDHzP54/7/GIZeQKGtT4DTUw6mNd17xPb4cg7c8KBwV8dlXKF YLzbFw83zF0Zb0G8ge/5b/iDnAwLSMGPs5+TVnZvAvT3DaSU1gCqbEu9FgwYtsrNG3Ci GoxrsHIYX7ppgGex2ZCpbwT7GrTdRk/Xhde982tfs6f80iRboDBdtpdtXpt6JGZl1/1K nI3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=014EeENY2me/qFzfkddDJOfJfDVf12g0AgfnrXRnuq8=; b=YZGQWVO3YQDVTNQ5ZrdmnYrsPHsKKioa8ufrrPDQJPfJBRwGV3jkNyKo/e0Uu1VOcH 2RNqh3Hn3SDdM7Pb1LAX1LdCU9vqpIvXsPaoZp5OYtorgbWPM0YbZXj7F7ELBUAo2C/2 CSUrx+8NIRe/hE2ybJ15LErpdbi6rMFlRYM9SC1rMqRhihYY9r9X7BsugdpXapU7cans 4SmDiJEjHaBFDR8DIxGCdbwLgbIWxwzWKrbXywqJ5rXrnGy8S03upLBkRjduzSBUOGlw kth20FHqHMwppPdM4Yai2q46GDo8LLPBLFXWUAi8fXGsTq/rwAWqZRmCiZTM5SD0bC9i Pr8w== X-Gm-Message-State: AOPr4FWVwWXHzBLKNa+1ykQqWrc1pwZgxQam2oLyOJh/mciWFNJ3xYkY28StknEyAnVkeu0tGagRx0jLcF4Pdw== MIME-Version: 1.0 X-Received: by 10.50.32.102 with SMTP id h6mr24968268igi.16.1461776142831; Wed, 27 Apr 2016 09:55:42 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.79.104.197 with HTTP; Wed, 27 Apr 2016 09:55:42 -0700 (PDT) X-Originating-IP: [69.53.245.25] In-Reply-To: <20160427162611.GQ26116@ivaldir.etoilebsd.net> References: <201604271527.u3RFRNh3082189@repo.freebsd.org> <20160427161359.GP26116@ivaldir.etoilebsd.net> <20160427162611.GQ26116@ivaldir.etoilebsd.net> Date: Wed, 27 Apr 2016 12:55:42 -0400 X-Google-Sender-Auth: 8PnMpAo9ckN1uVSDELSrQ8DNmpI Message-ID: Subject: Re: svn commit: r298701 - in projects/zfsd/head: cddl/sbin/zfsd share/mk From: Warner Losh To: Baptiste Daroussin Cc: Alan Somers , "src-committers@freebsd.org" , svn-src-projects@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2016 16:55:43 -0000 On Wed, Apr 27, 2016 at 12:26 PM, Baptiste Daroussin wrote: > On Wed, Apr 27, 2016 at 10:20:19AM -0600, Alan Somers wrote: > > On Wed, Apr 27, 2016 at 10:13 AM, Baptiste Daroussin > > wrote: > > > > > On Wed, Apr 27, 2016 at 03:27:23PM +0000, Alan Somers wrote: > > > > Author: asomers > > > > Date: Wed Apr 27 15:27:23 2016 > > > > New Revision: 298701 > > > > URL: https://svnweb.freebsd.org/changeset/base/298701 > > > > > > > > Log: > > > > Replace LDADD with LIBADD and NO_MAN with MK_MAN > > > > > > > > Sponsored by: Spectra Logic Corp > > > > > > > > Modified: > > > > projects/zfsd/head/cddl/sbin/zfsd/Makefile.common > > > > projects/zfsd/head/share/mk/src.libnames.mk > > > > > > > > Modified: projects/zfsd/head/cddl/sbin/zfsd/Makefile.common > > > > > > > > ============================================================================== > > > > --- projects/zfsd/head/cddl/sbin/zfsd/Makefile.common Wed Apr 27 > > > 15:25:18 2016 (r298700) > > > > +++ projects/zfsd/head/cddl/sbin/zfsd/Makefile.common Wed Apr 27 > > > 15:27:23 2016 (r298701) > > > > @@ -10,7 +10,7 @@ SRCS= callout.cc \ > > > > zpool_list.cc \ > > > > zfsd_main.cc > > > > > > > > -NO_MAN= YES > > > > +MK_MAN= no > > > > > > This is supposed to be: > > > MAN= > > > > > > with no value assigned and not MK_MAN > > > > > > Best regards, > > > Bapt > > > > > > > Ok, I'll change it. Is that a recent change? When it was still NO_MAN, > > make printed an error advising me to use "MK_MAN=no". > > I do not remember when this change happened but iirc it was long ago (I do > not > also remember about the advice). > > All I know is there are 334 MAN= and only 3 MK_MAN=no. Others might know > better > (Warner?) > There should be zero MK_MAN=no. That's always an error to set in a Makefile in the tree (though we set it for some phaes in Makefile.inc1 during buildworld). We transitioned from NO_MAN=yes to MAN= when we reworked where the man pages were installed. This was in r74806 when ru@ changed the list of man pages. If MAN was empty no man pages are installed. This was only 15 years ago... The reason for the change was that you can't easily change a default so we eliminated all the NO options that were user visible into MK options. But MK options are supposed to only be set by WITHOUT_ and WITH_ options and never directly by Makefile or by user action (though we've relaxed it a bit for buildworld things in Makefile.inc1). Warner