From owner-cvs-src@FreeBSD.ORG Sun Jul 31 18:59:06 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A4D016A41F; Sun, 31 Jul 2005 18:59:06 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from postfix4-2.free.fr (postfix4-2.free.fr [213.228.0.176]) by mx1.FreeBSD.org (Postfix) with ESMTP id E46F743D48; Sun, 31 Jul 2005 18:59:05 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from tatooine.tataz.chchile.org (vol75-8-82-233-239-98.fbx.proxad.net [82.233.239.98]) by postfix4-2.free.fr (Postfix) with ESMTP id AF92D323457; Sun, 31 Jul 2005 20:59:04 +0200 (CEST) Received: by tatooine.tataz.chchile.org (Postfix, from userid 1000) id EF524405B; Sun, 31 Jul 2005 20:59:25 +0200 (CEST) Date: Sun, 31 Jul 2005 20:59:25 +0200 From: Jeremie Le Hen To: Alexander Leidinger Message-ID: <20050731185925.GU68965@obiwan.tataz.chchile.org> References: <200507292145.j6TLjkNc099549@repoman.freebsd.org> <86k6j8g7mq.fsf@xps.des.no> <20050730124053.507227dd@Magellan.Leidinger.net> <863bpvmnww.fsf@xps.des.no> <20050731102343.35bc4aa9@Magellan.Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050731102343.35bc4aa9@Magellan.Leidinger.net> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2005 18:59:06 -0000 Hi Alexander, > > BTW, I don't really see why {check,delete}-old-* should be restricted > > to native environments. DESTDIR might point to e.g. an NFS-exported > > filesystem from which thin clients of a different architecture boot. > > Because of ObsoleteFiles.inc: > ---snip--- > .if ${MACHINE_ARCH} != "alpha" && ${MACHINE_ARCH} != "sparc64" > # 20040130: libkse renamed to libpthread > OLD_FILES+=usr/lib/libkse.a > OLD_FILES+=usr/lib/libkse.so > .endif > ---snip--- > > We could change this to TARGET_ARCH instead, but then the user has to > set it, else he removes non-obsolete files. Even when we make it a > documented requirement, I don't have a good feeling regarding this. > There's too much foot-shooting potential if someone forgets to set it. > I think it's more user friendly / ergonomic to keep the current > restriction. With the restriction in place you need to have 2 > files (Makefile.inc1 and ObsoleteFiles.inc) or the NFS exported src > directory on one client to remove the old files. This is a little bit > more work, but forces the administrator to think a little bit about what > he does. It's part of my "as failsafe as possible" design of this > feature. This sounds as a hack, but couldn't you use file(1) on ${DESTDIR}/bin/ls to identify the architecture it's running ? It would at least avoid breaking POLA. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >