From nobody Tue Aug 16 11:47:59 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M6Tt72wN1z4Yt41; Tue, 16 Aug 2022 11:47:59 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M6Tt72N1Sz49KR; Tue, 16 Aug 2022 11:47:59 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660650479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VZQ3Vo5Z0K+Arf8n+d5SdMXE7iTQJdRTOSFM2kRsSNc=; b=aU6CaC5t3IXAN0TTUBSYYocYfxbUACtDZhyA7AyY/O5nW/HFPUQeCwjmlMVcjCExPjcYh7 XijX3vb/GnPI4MPI6rvGSa30pc6p8w+rkI+OL2H5bfQv0oixXc5MHJcsItS6ULHe3MTFh4 XozbdNX345Z05lJ0CZL20H7ggvYJg+/yk5BED4Wchxu+nQ+omgaPA9kNXJCM9VctlepiVc dtKhA1XO+OFwnHICJMp5Zqb5Jffv2Yq1O9pBnBkQ9Z3Rs1Fd/drwoeYUGAoNbmUWXYyARE B1GfmBFt31rpWFvKjVHprjvV+Imt9lansv1uAQKZG9Xeq7zmQaXLi1iUvLI+QA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2F1CA96F8; Tue, 16 Aug 2022 11:47:59 +0000 (UTC) Date: Tue, 16 Aug 2022 11:47:59 +0000 From: Alexey Dokuchaev To: Dimitry Andric Cc: Jessica Clarke , Konstantin Belousov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Message-ID: References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660650479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VZQ3Vo5Z0K+Arf8n+d5SdMXE7iTQJdRTOSFM2kRsSNc=; b=WjPhIbCmpQ6JYnLqp8UtZcmHXZmQoIw294q19bmxZw6XPEydu0MJY1TrFfSSr8iqDAvfdK 92tn+ZRMXTcK5R/BHhS+qt2OUomCEAPt9yfoxYk5HMlr1cpDvOhdu8uyVmDLrZgFNt2KXd ifyRrXIjJ8k3yVkr98Hvk+c15+jj1ZinecRZc9qKo2cDRDaLW/SXNQEXT5euqxevDCtrpM uU94jtDFWJaPH2dF1EK1ftXOAYz7Vkcrh2LxGOCIz3jfs7YJHN1keGRvVc0+t9ActVAeQ9 huWKAMTnBhszS2FCqWtu0Ou+rWMgXkkZSdcBF/juARmHPRhxB4DHHM2MNoSQvA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660650479; a=rsa-sha256; cv=none; b=wsTpxgoq296j0Tw9ICG+fvb/i9TKxvVssPWNuwxsLnDQ840+wMumZR2L2xxs6OkCf2P4Qx ClSoI5RdFkrYP0YAuEkVETP4irSGwE2+EGQ1psuBbCybPXOoqB62RXAg4gOtDCjzsQYq0h hX8zJkMMiEvuaCNVbUhI58fBdaFIqar3OqCwUgAuA51nFb1ubgopjiTuYPOK/r44AXonLs vwZbji0EQSiVZIW6njdzEvGu+S0+h1gT2o7Cl5mxxZswc18KcQnaW9H7x9hYioiUWxIxj3 EvDuEp+VlT1gxKPlqxJfbUDFc/U1tydqoOH5jgxnZcTqpWCjzSVpppho/Y8GWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > ... > But I think it is better to have the definitions matching the > declarations exactly. We should sweep through the whole tree and get > rid of all K&R functions too. I believe Warner wanted to attempt that. I won't comment on the technical side of things, but seeing this plethora of identical commits is not just annoying, but pessimizes blaming as well. Why can't it all be done in more coarse pieces, if not one commit? ./danfe