Date: Wed, 19 Sep 2012 09:34:56 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Guido Falsi <madpilot@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Chris Rees <crees@FreeBSD.org>, svn-ports-all@freebsd.org, Thomas Abthorpe <tabthorpe@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r304474 - head/multimedia/cx88 Message-ID: <20120919093456.GA83232@FreeBSD.org> In-Reply-To: <20120919085406.GA10551@micro.madpilot.net> References: <201209182334.q8INYl5P083094@svn.freebsd.org> <20120919034244.GA29962@FreeBSD.org> <20120919085406.GA10551@micro.madpilot.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 19, 2012 at 10:54:06AM +0200, Guido Falsi wrote: > On Wed, Sep 19, 2012 at 03:42:44AM +0000, Alexey Dokuchaev wrote: > > - Created-by: tag is wrongly spelled and should be followed with tab I > > think > > Right. Going to fix this, but not completely sure about the tab rule, > anyway it's the same for me, if a tab is preferred I'll add one. I'm also not sure about the separator; it should be clarified. > > - $ finger jah@freebsd.org > > [freebsd.org] > > Trying 69.147.83.40... > > finger: jah: no such user > > > > - This should have been "Jason Harmening <jason.harmening@gmail.com>" > > > > - Even for FreeBSD committers, please use their fully qualified identities > > I intended to just rename the Whom: to Created by: and left the > identity as is. If a full identity is requested I'll ask the > maintainer if he approves this change(or prefers having just the > name or wants to remove the Created by: line). I think this is bad practice. Nicks are too ambiguous and reserved for FreeBSD committers by default (this is not an rule, but rather established historical practice). Using "informal" names also creates bad precedent, like it's OK to use bogus names like "Anonymous" (when it's not anonymous submittion, e.g. with email address; we have some of them already -- looks awful) or "4v1l h4c|<3r". > BTW there are other ports(not many I admit) with nicknames not > present @freebsd.org so I thought it was allowed practice to use > nicknames too. What if a contributor expresses preference for > inserting just a nickname there? Personally I think we should require standard full name (with optional decorations like III, .Sr, etc.) and politely ask why would one want to conceal it. After all, we require it when granting a commit bit. As a last resort, there is anonymity option for those who prefer not to reveal their full name. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120919093456.GA83232>