From owner-freebsd-arch@FreeBSD.ORG Thu Apr 20 16:44:51 2006 Return-Path: X-Original-To: arch@FreeBSD.ORG Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60B2E16A404 for ; Thu, 20 Apr 2006 16:44:51 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4CDA43D6B for ; Thu, 20 Apr 2006 16:44:46 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k3KGelRT024467; Thu, 20 Apr 2006 10:40:48 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 20 Apr 2006 10:40:48 -0600 (MDT) Message-Id: <20060420.104048.57443855.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <3731.1145513558@critter.freebsd.dk> References: <20060419.165709.22017808.imp@bsdimp.com> <3731.1145513558@critter.freebsd.dk> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@FreeBSD.ORG, gurney_j@resnet.uoregon.edu Subject: Re: remove rid pointer (but not rid)... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2006 16:44:51 -0000 In message: <3731.1145513558@critter.freebsd.dk> "Poul-Henning Kamp" writes: : In message <20060419.165709.22017808.imp@bsdimp.com>, "M. Warner Losh" writes: : : >This will, of course, be a big undertaking in the tree. There are : >1216 instances of the string 'alloc_resource' Every single one of : >them will need to change in some way. : : Most of them could beneficially change to use bus_alloc_resources(), : thereby improving the code (there are far too many bugs in the error : handling) and at the same time cutting the 1216 in half or further : down. Agreed. I think I made that point a little later in my post. The big difficulty here is testing the driver after the changes to make sure that no unintended bugs have been introduced. Warner