From owner-svn-src-head@freebsd.org Thu Jan 9 20:59:49 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C33B61F8DE2; Thu, 9 Jan 2020 20:59:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47tz5K4qNsz3CV1; Thu, 9 Jan 2020 20:59:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi1-f171.google.com with SMTP id n16so7127839oie.12; Thu, 09 Jan 2020 12:59:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=WrZSmRrHSOD+Bl1ECm1SPgiK+hWWSZtzhUvLFsjv5rI=; b=DwvSimgHk91mopcph74w9eyULsoQ8yH4ZlkznC4meYOhH0uSkqzOlDcqhPS+cwB9qj A0nM96VA7YicKDuN/dfAB9j488amVg2k3zC6HvvD3pWXpE30IEZ0QeZ8RYv1sRl6FmmW teQRcLlL0+JzwW37jn6XM4AHeEsDxYT275ivhdg9j+dl1DtQrwbEOWAtLH8KDKGb4ZWZ DbwV2tcm8idzYlUuHz11XJWz2w4XSA+P6EY5CutilqQW0JDjHbf3PIaxCYgf1UGXC+56 Y7uXwjzaV64G1BWwueHMIxXH7zDPHmKMbPDHaiqsWgVyD9WIxp+9wHTHmVsr7jCvIYwN EFhg== X-Gm-Message-State: APjAAAWouveWL8M/e9JKYyWoIcbhUtjm3vGnqI13/MxWz3a5o8rsX3++ mPw7iKlxWES/qKZ3rn3VeQbHUbp0 X-Google-Smtp-Source: APXvYqyrL7VYB7YVM5KzkBue94+0BVt+RU23bnGXidIIQkGUChwd1udB9Mxx3N1ghfzGetOQKGjcXw== X-Received: by 2002:aca:4c15:: with SMTP id z21mr4562455oia.8.1578603588268; Thu, 09 Jan 2020 12:59:48 -0800 (PST) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com. [209.85.210.50]) by smtp.gmail.com with ESMTPSA id i3sm2829246otr.31.2020.01.09.12.59.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2020 12:59:47 -0800 (PST) Received: by mail-ot1-f50.google.com with SMTP id i15so8700505oto.2; Thu, 09 Jan 2020 12:59:47 -0800 (PST) X-Received: by 2002:a05:6830:13d3:: with SMTP id e19mr10163855otq.135.1578603587783; Thu, 09 Jan 2020 12:59:47 -0800 (PST) MIME-Version: 1.0 References: <202001092049.009KnQPE069028@repo.freebsd.org> In-Reply-To: <202001092049.009KnQPE069028@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Thu, 9 Jan 2020 12:59:37 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r356569 - head/lib/libc/locale To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 47tz5K4qNsz3CV1 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2020 20:59:49 -0000 On Thu, Jan 9, 2020 at 12:49 Mark Johnston wrote: > Author: markj > Date: Thu Jan 9 20:49:26 2020 > New Revision: 356569 > URL: https://svnweb.freebsd.org/changeset/base/356569 > > Log: > libc: Fix a few bugs in the xlocale collation code. > > - Fix checks for mmap() failures. [1] > - Set the "map" and "maplen" fields of struct xlocale_collate so that > the table destructor actually does something. > - Free an already-mapped collation file before loading a new one into > the global table. > - Harmonize the prototype and definition of __collate_load_tables_l() by > adding the "static" qualifier to the latter. > > PR: 243195 > Reported by: cem [1] I appreciate the mention for my small role in this but the majority of the credit (PR report and solid initial diagnosis) should go to Koichi Murase . Best, Conrad