From owner-svn-ports-head@FreeBSD.ORG Tue Jul 23 16:15:23 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2225B409 for ; Tue, 23 Jul 2013 16:15:23 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0641827C2 for ; Tue, 23 Jul 2013 16:15:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r6NGFM41034854 for ; Tue, 23 Jul 2013 16:15:22 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r6NGFM6F034849 for svn-ports-head@freebsd.org; Tue, 23 Jul 2013 16:15:22 GMT (envelope-from bdrewery) Received: (qmail 6047 invoked from network); 23 Jul 2013 11:15:20 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 23 Jul 2013 11:15:20 -0500 Message-ID: <51EEAC10.4000004@FreeBSD.org> Date: Tue, 23 Jul 2013 11:15:12 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r323495 - head/games/f1lt References: <201307221916.r6MJG7Ln085934@svn.freebsd.org> <20130723070857.GB10232@FreeBSD.org> In-Reply-To: <20130723070857.GB10232@FreeBSD.org> X-Enigmail-Version: 1.5.1 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2JLPCBIWUGACSIGPAULHN" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Jason Helfman , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jul 2013 16:15:23 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JLPCBIWUGACSIGPAULHN Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 7/23/2013 2:08 AM, Alexey Dokuchaev wrote: > On Mon, Jul 22, 2013 at 07:16:07PM +0000, Jason Helfman wrote: >> New Revision: 323495 >> URL: http://svnweb.freebsd.org/changeset/ports/323495 >> >> Log: >> - drop default MAKE_JOBS_SAFE >=20 > Folks (not just Jason), >=20 > I think making such commits which touch one file and essentially do not= do > anything other than causing extra repo churn and noise (+ few thousands= > commit messages people will find in their mailboxes) is something we sh= ould > rather avoid. Removing MAKE_JOBS_SAFE while doing something else on th= e > port is fine. Removing MAKE_JOBS_SAFE in all ports you maintain, or al= l > ports in a category is also fine. Removing MAKE_JOBS_SAFE and nothing = else > from one Makefile per commit -- perhaps not that fine. >=20 > ./danfe >=20 Quite the contrary. If a change is needed it should be done now, not in 2 months or years when it is convenient. Smaller logical commits are much simpler to review and bisect than large commits. We should group PORTVERSION/PORTREVISION changes together to prevent *rebuild churn*. --=20 Regards, Bryan Drewery ------enig2JLPCBIWUGACSIGPAULHN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJR7qwUAAoJEG54KsA8mwz5vjkP/RqAKkpgVCx7MLt2Q+OvJw/F DcdOEf9k9JP/uvHKAiH1V3uX9EN2IrQaPo3Q58Ivrbwe2XcJv/R0MDWrm9hXRkw7 J8YrUp5L1T8Elkbcu9O33TzTOmWkZ7/CZh1oTBb0jFxQn9hTFN990WAR2RCzvPUA 6Qr6DFyP0CyFPGKzkcgqp2IYTatRk3pAM7t82kMach+91WnHcx5Wse3pe6l0yJd5 JqgUBnp2YMWlfcTza40MNKbWB9xTTMaYbTIitN5FtIr+TlDO04UXaoFKZKSJd5hM m3G0mtzaVOoejjRvmL0RcYDjhY7gEc6QqAlXXrIzijjzfkm276SebaE8rPQfZ4R2 P8CWACMbTSm8Ol/uUDcy9YvKPqHl29OKpLRr2j79orHpaKJ1vd8+VgQqrGJfNSVO jYMDGKulHe5fwUA7IMbtOsgm60imNiaRjPUiXVEK5IEiD0SnRSLAQGLjV71ecqQ1 zsaW89lLYTzniZkW+oVt7/N09IUVpHaZG1OJQlNZz45HX5CVXvY3Hh3ETGRFo69M 3ZSF4FsrJVV44wDO30DvcB9wvQqKbZ7NFYyrwVB3+t8b1HE4w3ttCmtOcWA1bdfE EUoggN5iS17s8yOOIUNwT2ijvYuRNUu1aWmZOiehNyLZZJH2lAQwVQix2xsqGoHQ XAp+78oZ6lhqOXeHRQRO =1R8R -----END PGP SIGNATURE----- ------enig2JLPCBIWUGACSIGPAULHN--