Date: Tue, 16 Aug 2022 06:59:04 -0600 From: Warner Losh <imp@bsdimp.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Dimitry Andric <dim@freebsd.org>, Jessica Clarke <jrtc27@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Message-ID: <CANCZdfp2ij-2uOFLKNyKzhPjAOW015YO=10N-YYhHVsnZygsqw@mail.gmail.com> In-Reply-To: <YvuSqgpQ/AnQKNVj@FreeBSD.org> References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> <Yvq1lQqmq3Mwv9ZJ@kib.kiev.ua> <F33312A7-B4B3-4D1A-9FE6-7CEF4E0F4BD9@freebsd.org> <A9D9B817-8E18-49A5-87A0-BDD9FA748549@FreeBSD.org> <YvuD7%2BoK6RZ/DLzH@FreeBSD.org> <4ed11043-d368-3084-bb21-2b794e9da748@FreeBSD.org> <YvuSqgpQ/AnQKNVj@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000ca3d0905e65b5005 Content-Type: text/plain; charset="UTF-8" On Tue, Aug 16, 2022 at 6:50 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Aug 16, 2022 at 02:41:51PM +0200, Dimitry Andric wrote: > > On 2022-08-16 13:47, Alexey Dokuchaev wrote: > > > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > > >> ... > > >> But I think it is better to have the definitions matching the > > >> declarations exactly. We should sweep through the whole tree and get > > >> rid of all K&R functions too. I believe Warner wanted to attempt that. > > > > > > I won't comment on the technical side of things, but seeing this > plethora > > > of identical commits is not just annoying, but pessimizes blaming as > well. > > > > I don't see any reason why this would "pessimize blaming"? What do you > > mean with that? > > Sorry, I've meant bisecting. Not sure why I used that word. > I don't believe this is a serious pessimization. Bisect will jump over these, on the average, with only a few strides. > > Because then somebody else will probably complain "why everything in one > > commit, it should be fine-grained"? > > I see; well, I believe a reasonable balance could be achieved, there are > a lot of numbers between 1 and 100. :) > The 50 other sweeps that we've done since the git conversions have been done exactly this way, though doing it by directory might not be terrible in some cases. My complaint is that the commit message should be 'Stop using K&R function definitions.' or similar, not 'fix a warning in clang' because the former has possibly useful content, while the latter's content is more ephemeral. But in reality, it isn't a huge deal either way. Warner --000000000000ca3d0905e65b5005 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Tue, Aug 16, 2022 at 6:50 AM Alexe= y Dokuchaev <<a href=3D"mailto:danfe@freebsd.org">danfe@freebsd.org</a>&= gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0= px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tu= e, Aug 16, 2022 at 02:41:51PM +0200, Dimitry Andric wrote:<br> > On 2022-08-16 13:47, Alexey Dokuchaev wrote:<br> > > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote:<b= r> > >> ...<br> > >> But I think it is better to have the definitions matching the= <br> > >> declarations exactly. We should sweep through the whole tree = and get<br> > >> rid of all K&R functions too. I believe Warner wanted to = attempt that.<br> > > <br> > > I won't comment on the technical side of things, but seeing t= his plethora<br> > > of identical commits is not just annoying, but pessimizes blaming= as well.<br> > <br> > I don't see any reason why this would "pessimize blaming"= ;? What do you<br> > mean with that?<br> <br> Sorry, I've meant bisecting.=C2=A0 Not sure why I used that word.<br></= blockquote><div><br></div><div>I don't believe this is a serious pessim= ization.=C2=A0 Bisect will jump over these, on the</div><div>average, with = only a few strides.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote"= style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p= adding-left:1ex"> > Because then somebody else will probably complain "why everything= in one<br> > commit, it should be fine-grained"?<br> <br> I see; well, I believe a reasonable balance could be achieved, there are<br= > a lot of numbers between 1 and 100. :)<br></blockquote><div><br></div><div>= The 50 other sweeps that we've done since the git conversions have been= done</div><div>exactly this way, though doing it by directory might not be= terrible in some cases.</div><div><br></div><div>My complaint is that the = commit message should be 'Stop using K&R function</div><div>definit= ions.' or similar, not 'fix a warning in clang' because the for= mer has possibly</div><div>useful content, while the latter's content i= s more ephemeral. But in reality, it isn't</div><div>a huge deal either= way.</div><div><br></div><div>Warner=C2=A0</div></div></div> --000000000000ca3d0905e65b5005--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp2ij-2uOFLKNyKzhPjAOW015YO=10N-YYhHVsnZygsqw>