From owner-freebsd-bugs@FreeBSD.ORG Sat Oct 10 19:20:01 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B03E51065694 for ; Sat, 10 Oct 2009 19:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8A48E8FC1B for ; Sat, 10 Oct 2009 19:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9AJK1Uq078180 for ; Sat, 10 Oct 2009 19:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9AJK1eY078179; Sat, 10 Oct 2009 19:20:01 GMT (envelope-from gnats) Resent-Date: Sat, 10 Oct 2009 19:20:01 GMT Resent-Message-Id: <200910101920.n9AJK1eY078179@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Bruce Cran Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B7D4B106568D for ; Sat, 10 Oct 2009 19:19:05 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A70B48FC12 for ; Sat, 10 Oct 2009 19:19:05 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n9AJJ5Oj039108 for ; Sat, 10 Oct 2009 19:19:05 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n9AJJ4ZR039107; Sat, 10 Oct 2009 19:19:04 GMT (envelope-from nobody) Message-Id: <200910101919.n9AJJ4ZR039107@www.freebsd.org> Date: Sat, 10 Oct 2009 19:19:04 GMT From: Bruce Cran To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/139492: pkg_install - overlapping data buffer in call to snprintf X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Oct 2009 19:20:01 -0000 >Number: 139492 >Category: bin >Synopsis: pkg_install - overlapping data buffer in call to snprintf >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Oct 10 19:20:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Bruce Cran >Release: 8.0-RC1 >Organization: >Environment: FreeBSD bsd01.localdomain 8.0-RC1 FreeBSD 8.0-RC1 #0: Thu Sep 17 20:45:19 UTC 2009 root@almedia.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: On line 270 of usr.sbin/pkg_install/lib/match.c there's a call to snprintf which uses an overlapping buffer: snprintf(tmp, PATH_MAX, "%s/%s", tmp, CONTENTS_FNAME); According to http://www.opengroup.org/onlinepubs/000095399/functions/printf.html the results are undefined in the buffers overlap. >How-To-Repeat: Install devel/cppcheck and run it in usr.sbin/pkg_install >Fix: >Release-Note: >Audit-Trail: >Unformatted: