From owner-freebsd-bugs@FreeBSD.ORG Sat Apr 2 18:50:11 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 094C4106566C for ; Sat, 2 Apr 2011 18:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DCF7B8FC13 for ; Sat, 2 Apr 2011 18:50:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p32IoAMJ064683 for ; Sat, 2 Apr 2011 18:50:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p32IoAdl064682; Sat, 2 Apr 2011 18:50:10 GMT (envelope-from gnats) Resent-Date: Sat, 2 Apr 2011 18:50:10 GMT Resent-Message-Id: <201104021850.p32IoAdl064682@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rozhuk Ivan Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0531106564A for ; Sat, 2 Apr 2011 18:43:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 91ACA8FC08 for ; Sat, 2 Apr 2011 18:43:35 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p32IhZTI088959 for ; Sat, 2 Apr 2011 18:43:35 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p32IhZQp088953; Sat, 2 Apr 2011 18:43:35 GMT (envelope-from nobody) Message-Id: <201104021843.p32IhZQp088953@red.freebsd.org> Date: Sat, 2 Apr 2011 18:43:35 GMT From: Rozhuk Ivan To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/156130: hints read: resource_longlong_value and resource_uintmax_value X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Apr 2011 18:50:11 -0000 >Number: 156130 >Category: kern >Synopsis: hints read: resource_longlong_value and resource_uintmax_value >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sat Apr 02 18:50:10 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Rozhuk Ivan >Release: 8.2-STABLE >Organization: >Environment: FreeBSD firewall 8.2-STABLE FreeBSD 8.2-STABLE #4: Sun Mar 13 02:12:50 IRKT 2011 root@firewall:/usr/obj/usr/src/sys/RIMx64 amd64 >Description: just additional functions for hints: resource_longlong_value resource_uintmax_value >How-To-Repeat: try to read from "hints" 64 bit values in your driver/module >Fix: apply patch :) Patch attached with submission follows: --- /usr/src/sys/kern/subr_hints_orig.c 2009-08-03 17:13:06.000000000 +0900 +++ /usr/src/sys/kern/subr_hints.c 2011-04-03 02:28:25.000000000 +0900 @@ -273,6 +273,53 @@ resource_long_value(const char *name, in return 0; } + +int +resource_longlong_value(const char *name, int unit, const char *resname, unsigned long long *result) +{ + int error; + const char *str; + char *op; + unsigned long val; + int line; + + line = 0; + error = resource_find(&line, NULL, name, &unit, resname, NULL, + NULL, NULL, NULL, NULL, NULL, &str); + if (error) + return error; + if (*str == '\0') + return EFTYPE; + val = strtoull(str, &op, 0); + if (*op != '\0') + return EFTYPE; + *result = val; + return 0; +} + +int +resource_uintmax_value(const char *name, int unit, const char *resname, uintmax_t *result) +{ + int error; + const char *str; + char *op; + unsigned long val; + int line; + + line = 0; + error = resource_find(&line, NULL, name, &unit, resname, NULL, + NULL, NULL, NULL, NULL, NULL, &str); + if (error) + return error; + if (*str == '\0') + return EFTYPE; + val = strtoumax(str, &op, 0); + if (*op != '\0') + return EFTYPE; + *result = val; + return 0; +} + int resource_string_value(const char *name, int unit, const char *resname, const char **result) >Release-Note: >Audit-Trail: >Unformatted: