From owner-svn-src-all@freebsd.org Tue Sep 3 14:07:57 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E36DDD404; Tue, 3 Sep 2019 14:07:04 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N8075nDPz4QCG; Tue, 3 Sep 2019 14:07:03 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 4C46A1B01E; Tue, 3 Sep 2019 14:06:27 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 065171FE55; Thu, 18 Apr 2019 04:06:06 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 365D474DDB; Thu, 18 Apr 2019 04:06:05 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 17BC51FDEE; Thu, 18 Apr 2019 04:06:05 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 342D71FDE9; Thu, 18 Apr 2019 04:06:02 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5531674DD4; Thu, 18 Apr 2019 04:06:00 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id GyJ9hl9Cfo7SQGyJAh1tID; Wed, 17 Apr 2019 22:05:58 -0600 X-Authority-Analysis: v=2.3 cv=Go88BX9C c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=oexKYjalfGEA:10 a=6I5d2MoRAAAA:8 a=iKhvJSA4AAAA:8 a=iaTFZB6CAAAA:8 a=zxA2vyXaAAAA:8 a=YxBL1-UpAAAA:8 a=L7ZJcP9EYGOl6B3A_wAA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=odh9cflL3HIXMm4fY7Wr:22 a=QWXrQ9iV8q7LKaLQ9lfw:22 a=nK2txNHJmq7TfjpuLlwI:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id E20546D5; Wed, 17 Apr 2019 21:05:54 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x3I45sIc050488; Wed, 17 Apr 2019 21:05:54 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x3I45sQo050485; Wed, 17 Apr 2019 21:05:54 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201904180405.x3I45sQo050485@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Ian Lepore cc: Cy Schubert , rgrimes@freebsd.org, Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346341 - head/tools/build In-Reply-To: Message from Ian Lepore of "Wed, 17 Apr 2019 21:58:55 -0600." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-CMAE-Envelope: MS4wfExrx2ewOWNds1FaxKlSB4fCz3lG4cQl2/6A8+VhAQ0KQfYJ8uhMfjwRrfAH/U8sN/UTBrq7hSt8K2JRjWwaNP+4dmS79q60UK7BFFgXEHY6E9O84OGm aTjEtHGYavt/aMs9uqa2eT3eu+uv8qQUZTmkAEQKLTZej2/PE6WMhfb0fD/ZD5mOrw0ej4G9e8+JEwEVA2gwfAu2l9rVoi1BUglkZmazaythsnQgl6epYD1m llGh5RfjG1hyDIgtI1v4xdy7K2qxl94WhcYc0R6941i1HMCDiQaiNuiblievgB/+2XJTeEmzsqz6fvGgweYmHNlGUu49p87I+O6ar/29aD0= Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 365D474DDB X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:57 -0000 X-Original-Date: Wed, 17 Apr 2019 21:05:54 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:07:57 -0000 In message , Ian Le pore writes: > On Wed, 2019-04-17 at 20:32 -0700, Cy Schubert wrote: > > In message <201904180107.x3I17QDc002945@gndrsh.dnsmgr.net>, "Rodney > > W. > > Grimes" > > writes: > > > > Author: cy > > > > Date: Thu Apr 18 01:02:00 2019 > > > > New Revision: 346341 > > > > URL: https://svnweb.freebsd.org/changeset/base/346341 > > > > > > > > Log: > > > > As an interim measure until a more permanent solution is > > > > implemented > > > > workaround the following error: > > > > > > > > /usr/src/contrib/elftoolchain/strings/strings.c:198:55: error: > > > > use of > > > > undeclared identifier > > > > 'FA_OPEN' fa = fileargs_init(argc, argv, O_RDONLY, 0, &rights, > > > > FA_OPEN); > > > > > > > > Reported by: O. Hartmann > > > > Reported by: Michael Butler > > > > Reported by: gjb@ & cy@ (implicit) > > > > Reviewed by: emaste@ > > > > Noted by: rgrimes@ > > > > > > > > Modified: > > > > head/tools/build/Makefile > > > > > > > > Modified: head/tools/build/Makefile > > > > ================================================================= > > > > ========== > > > > > > === > > > > --- head/tools/build/Makefile Thu Apr 18 00:38:54 2019 ( > > > > r34634 > > > > > > 0) > > > > +++ head/tools/build/Makefile Thu Apr 18 01:02:00 2019 ( > > > > r34634 > > > > > > 1) > > > > @@ -59,9 +59,7 @@ INCS+= capsicum_helpers.h > > > > INCS+= libcasper.h > > > > .endif > > > > > > > > -.if !exists(/usr/include/casper/cap_fileargs.h) > > > > CASPERINC+= ${SRCTOP}/lib/libcasper/services/cap_fileargs/c > > > > ap_filea > > > > > > rgs.h > > > > -.endif > > > > > > As a further note, we should probably hunt for any thing > > > that is explicity looking at /usr/include/... in a Makefile, > > > as that is minimally missing a ${DESTDIR} argument. > > > > > > The above may of actually worked if it had been written: > > > .if !exists(${DESTDIR}/usr/include/casper/cap_fileargs.h) > > > someone may wish to test that. > > > > > > Also a pathname rooted at / without ${DESTDIR} is almost certainly > > > a mistake. > > > > This is a better solution. I tested this in a tree with a duplicated > > environment: Problem solved. Before this is committed it should be > > tested on one of the universe machines. > > > > > > I'm having a hard time understanding how adding $DESTDIR is any kind of > solution to something that happens at build time as opposed to install > time. I typically run buildworld/kernel without DESTDIR defined. $DESTDIR is also used as a destination for the temporary build directory $WORLDTMP, i.e. /usr/obj/${ARCH}/tmp, also known as $SYSROOT. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.