Date: Wed, 09 Oct 2002 14:08:05 -0700 From: Peter Wemm <peter@wemm.org> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: Jeff Roberson <jroberson@chesapeake.net>, gibbs@freebsd.org, current@freebsd.org Subject: Re: alpha tinderbox failure Message-ID: <20021009210805.042802A88D@canning.wemm.org> In-Reply-To: <15780.18620.457682.641298@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrew Gallatin wrote:
>
> Jeff Roberson writes:
> >
> >
> > On Tue, 8 Oct 2002, Dag-Erling Smorgrav wrote:
> > > "Makefile", line 4194: warning: duplicate script for target "geom_bsd.o"
ignored
> > > cc1: warnings being treated as errors
> > > /h/des/src/sys/dev/advansys/adv_pci.c: In function `adv_pci_attach':
> > > /h/des/src/sys/dev/advansys/adv_pci.c:197: warning: overflow in implicit
constant conversion
> > > *** Error code 1
> >
> > Any progress on this?
>
> This particular message is caused by alpha's
>
> #define BUS_SPACE_UNRESTRICTED (~0UL)
>
> Clashing with int nsegments:
>
> /* XXX Should probably allow specification of alignment */
> int bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignemnt,
> bus_size_t boundary, bus_addr_t lowaddr,
> bus_addr_t highaddr, bus_dma_filter_t *filtfunc,
> void *filtfuncarg, bus_size_t maxsize, int nsegments,
> bus_size_t maxsegsz, int flags, bus_dma_tag_t *dmat);
>
>
>
> Sparc64 has the same problem. ia64 gets around it by just making
> BUS_SPACE_UNRESTRICTED an int:
>
> #define BUS_SPACE_UNRESTRICTED (~0)
>
> I'd like to do the same for alpha. I think this is valid, as
> BUS_SPACE_UNRESTRICTED seems to be used exlusively as an argument
> to bus_dma_tag_create(... nsegments = BUS_SPACE_UNRESTRICTED...)
>
> I'd also like to add a bus_space_subregion().
Please feel free to change the workaround that I did. I wasn't sure if
changing the type of BUS_SPACE_UNRESTRICTED was safe.
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021009210805.042802A88D>