From owner-cvs-all@FreeBSD.ORG Fri Oct 8 14:24:50 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A593C16A4CE; Fri, 8 Oct 2004 14:24:50 +0000 (GMT) Received: from mail.acropolis.ru (mail.acropolis.ru [81.211.90.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB48F43D48; Fri, 8 Oct 2004 14:24:49 +0000 (GMT) (envelope-from slw@zxy.spb.ru) Received: from mail.acropolis.ru (localhost.acropolis.ru [127.0.0.1]) by mail.acropolis.ru (8.13.1/8.13.1) with ESMTP id i98EONDY087360; Fri, 8 Oct 2004 18:24:23 +0400 (MSD) (envelope-from slw@zxy.spb.ru) Received: (from slw@localhost) by mail.acropolis.ru (8.13.1/8.13.1/Submit) id i98EOMdN087358; Fri, 8 Oct 2004 18:24:22 +0400 (MSD) (envelope-from slw@zxy.spb.ru) X-Authentication-Warning: mail.acropolis.ru: slw set sender to slw@zxy.spb.ru using -f Date: Fri, 8 Oct 2004 18:24:22 +0400 From: Slawa Olhovchenkov To: "M. Warner Losh" Message-ID: <20041008142421.GA24021@mail.acropolis.ru> References: <200410041313.i94DDN1w064795@repoman.freebsd.org> <20041004.095538.105191591.imp@bsdimp.com> <20041004223426.GJ460@wantadilla.lemis.com> <20041004.163808.73381384.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041004.163808.73381384.imp@bsdimp.com> User-Agent: Mutt/1.5.6i X-Spam-Status: No, hits=-4.9 required=15.0 tests=BAYES_00 autolearn=ham version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on mail.acropolis.ru cc: grog@freebsd.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: phk@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2004 14:24:50 -0000 On Mon, Oct 04, 2004 at 04:38:08PM -0600, M. Warner Losh wrote: > In message: <20041004223426.GJ460@wantadilla.lemis.com> > "Greg 'groggy' Lehey" writes: > : On Monday, 4 October 2004 at 9:55:38 -0600, M. Warner Losh wrote: > : > In message: <200410041313.i94DDN1w064795@repoman.freebsd.org> > : > Poul-Henning Kamp writes: > : >> phk 2004-10-04 13:13:23 UTC > : >> > : >> FreeBSD src repository > : >> > : >> Modified files: > : >> sys/kern kern_shutdown.c > : >> Log: > : >> Change the perfectly precise message > : >> printf("No buffers busy after final sync"); > : >> to > : >> printf("All buffers synced."); > : >> in order to not leave the users wondering if there should be. > : > > : > Any not reason to delete > : > printf("All buffers synced."); > : > entirely? > : > : I like to see some message to confirm that the process is over and > : done with. Something goes wrong often enough that it's good to know > : that it worked this time. > > The machine will either shutoff, reboot or print the 'hit any key to > reboot' message in addition. ... or get kernel trap (intel MB D865GBF w/ P4 3Ghz 90nm, last current/5.3-B7). > Do we really need an additional message > saying that we did the right thing? It's good. -- Slawa Olhovchenkov