Date: Tue, 16 Aug 2022 08:51:58 -0600 From: Warner Losh <imp@bsdimp.com> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Dimitry Andric <dim@freebsd.org>, Jessica Clarke <jrtc27@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Message-ID: <CANCZdfr4T43efqopwG%2BZdxzBWw1gD7SNeD5VVcb273xATOu7Dw@mail.gmail.com> In-Reply-To: <20220816140000.365C5150@slippy.cwsent.com> References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> <Yvq1lQqmq3Mwv9ZJ@kib.kiev.ua> <F33312A7-B4B3-4D1A-9FE6-7CEF4E0F4BD9@freebsd.org> <A9D9B817-8E18-49A5-87A0-BDD9FA748549@FreeBSD.org> <YvuD7%2BoK6RZ/DLzH@FreeBSD.org> <20220816140000.365C5150@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000958a4f05e65ce46d Content-Type: text/plain; charset="UTF-8" On Tue, Aug 16, 2022, 8:00 AM Cy Schubert <Cy.Schubert@cschubert.com> wrote: > In message <YvuD7+oK6RZ/DLzH@FreeBSD.org>, Alexey Dokuchaev writes: > > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > > > ... > > > But I think it is better to have the definitions matching the > > > declarations exactly. We should sweep through the whole tree and get > > > rid of all K&R functions too. I believe Warner wanted to attempt that. > > > > I won't comment on the technical side of things, but seeing this plethora > > of identical commits is not just annoying, but pessimizes blaming as > well. > > Why can't it all be done in more coarse pieces, if not one commit? > > Agreed. > I'd prefer one burst. Cherry picking large commit that have conflicts is a real pain. Especially since the pain is different for 12 and 13. Especially since things get MFCd at different rates by different people. As someone who has had to sort that out multiple times, I know I've spent quite a bit more time unwinding one larger commit that was partially merged before I got there. It was terrible. It creates a lot of extra work for the mergers. Think boot loader that takes a while to settle before a lot of changes are mfc'd due to its huge number of combinatorics (hundreds of boot combinations) which take a while to have enough testing to know we've mitigated the risk as best we can, not all by me or even all in src/stand. With lots of commits, the lists are long but easily automated with any conflicts being quick and fast to resolve. Larger commits are bigger efforts to resolve making it harder to provide good support to old branches. And that's already hard enough. Also with one burst, it's just a range delete in my email client once. Warner > > -- > Cheers, > Cy Schubert <Cy.Schubert@cschubert.com> > FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org > NTP: <cy@nwtime.org> Web: https://nwtime.org > > e**(i*pi)+1=0 > > > --000000000000958a4f05e65ce46d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Tue, Aug 16, 2022, 8:00 AM Cy Schubert <<a href= =3D"mailto:Cy.Schubert@cschubert.com" target=3D"_blank" rel=3D"noreferrer">= Cy.Schubert@cschubert.com</a>> wrote:<br></div><blockquote class=3D"gmai= l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left= :1ex">In message <YvuD7+oK6RZ/DLzH@FreeBSD.org>, Alexey Dokuchaev wri= tes:<br> > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote:<br> > > ...<br> > > But I think it is better to have the definitions matching the<br> > > declarations exactly. We should sweep through the whole tree and = get<br> > > rid of all K&R functions too. I believe Warner wanted to atte= mpt that.<br> ><br> > I won't comment on the technical side of things, but seeing this p= lethora<br> > of identical commits is not just annoying, but pessimizes blaming as w= ell.<br> > Why can't it all be done in more coarse pieces, if not one commit?= <br> <br> Agreed.<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D= "auto">I'd prefer one burst. Cherry picking large commit that have conf= licts is a real pain. Especially since the pain is different for 12 and 13.= Especially since things get MFCd at different rates by different people. A= s someone who has had to sort that out multiple times, I know I've spen= t quite a bit more time unwinding one larger commit that was partially merg= ed before I got there. It was terrible. It creates a lot of extra work for = the mergers. Think boot loader that takes a while to settle before a lot of= changes are mfc'd due to its huge number of combinatorics (hundreds of= boot combinations) which take a while to have enough testing to know we= 9;ve mitigated the risk as best we can, not all by me or even all in src/st= and. With lots of commits, the lists are long but easily automated with any= conflicts being quick and fast to resolve. Larger commits are bigger effor= ts to resolve making it harder to provide good support to old branches. And= that's already hard enough.</div><div dir=3D"auto"><br></div><div dir= =3D"auto">Also with one burst, it's just a range delete in my email cli= ent once.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Warner</div><d= iv dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote= " style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> -- <br> Cheers,<br> Cy Schubert <<a href=3D"mailto:Cy.Schubert@cschubert.com" rel=3D"norefer= rer noreferrer" target=3D"_blank">Cy.Schubert@cschubert.com</a>><br> FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 <a href= =3D"http://www.FreeBSD.org" rel=3D"noreferrer noreferrer noreferrer" target= =3D"_blank">http://www.FreeBSD.org</a><br>; NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<<a href=3D"mailto:cy@nwtim= e.org" rel=3D"noreferrer noreferrer" target=3D"_blank">cy@nwtime.org</a>>= ;=C2=A0 =C2=A0 Web:=C2=A0 <a href=3D"https://nwtime.org" rel=3D"noreferrer = noreferrer noreferrer" target=3D"_blank">https://nwtime.org</a><br>; <br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 e**(i*pi)+1=3D0<br> <br> <br> </blockquote></div></div></div> --000000000000958a4f05e65ce46d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr4T43efqopwG%2BZdxzBWw1gD7SNeD5VVcb273xATOu7Dw>