From owner-cvs-all Tue Sep 10 14:58:17 2002 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id B5E0D37B400; Tue, 10 Sep 2002 14:58:12 -0700 (PDT) Date: Tue, 10 Sep 2002 14:58:12 -0700 From: Juli Mallett To: Tony Finch Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/uudecode uudecode.c Message-ID: <20020910145812.B78992@FreeBSD.org> References: <200209102053.g8AKrkvc055026@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200209102053.g8AKrkvc055026@freefall.freebsd.org>; from fanf@FreeBSD.org on Tue, Sep 10, 2002 at 01:53:46PM -0700 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: Tony Finch [ Data: 2002-09-10 ] [ Subjecte: cvs commit: src/usr.bin/uudecode uudecode.c ] > fanf 2002/09/10 13:53:46 PDT > > Modified files: > usr.bin/uudecode uudecode.c > Log: > Style: Don't treat pointers as booleans. Do we have a firm style(9) ruling on that? There's like two cases I know of where it's justified, both are code that return pointers, and use 0 / false internally. I loathe if(ptr) almost as much as if(foo &bitmask) and if(!strcmp) -- Juli Mallett | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message