From owner-cvs-lib Sun Jun 29 11:52:34 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id LAA12923 for cvs-lib-outgoing; Sun, 29 Jun 1997 11:52:34 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id LAA12915; Sun, 29 Jun 1997 11:52:28 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id EAA08740; Mon, 30 Jun 1997 04:51:45 +1000 Date: Mon, 30 Jun 1997 04:51:45 +1000 From: Bruce Evans Message-Id: <199706291851.EAA08740@godzilla.zeta.org.au> To: bde@zeta.org.au, jkh@time.cdrom.com Subject: Re: cvs commit: src/lib/libc/gen stringlist.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, jkh@FreeBSD.ORG Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> > Log: >> > _err() -> err(). >> >> Error! Library functions should not call functions in the user namespace. > >Well, it nuked my builds of -current (with "missing symbol __err") so >I figured having it outright broken wasn't a good idea either. What >do you suggest? Do you use ftp in the build? The missing `_err' seems to be harmless unless it is actually called. There seems to be no better correct quick fix than using weak aliases and renaming `err' to `_err' and `verr' to `_verr' (renaming `err' alone is insufficient since it calls `verr'). I think I prefer to do the renaming using macro hacks like the ones in . Bruce