From owner-cvs-all Wed Sep 12 22:40:43 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 8A28137B40B; Wed, 12 Sep 2001 22:40:20 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f8D5eFJ11846; Thu, 13 Sep 2001 08:40:15 +0300 (EEST) (envelope-from ru) Date: Thu, 13 Sep 2001 08:40:15 +0300 From: Ruslan Ermilov To: Dag-Erling Smorgrav Cc: David Malone , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c Message-ID: <20010913084015.A10963@sunbay.com> References: <200109130509.f8D59Er66909@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200109130509.f8D59Er66909@freefall.freebsd.org>; from des@FreeBSD.org on Wed, Sep 12, 2001 at 10:09:14PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This fix is wrong, please back it out. Please look at the code fragment which starts with the following comment: /* skip messages with the incorrect hostname */ And realize that the '+' should be in f_host[0]. Please also look at the audit trail for the below mentioned PR, and see the exlpanations from David and me. And please also take you hat back. On Wed, Sep 12, 2001 at 10:09:14PM -0700, Dag-Erling Smorgrav wrote: > des 2001/09/12 22:09:14 PDT > > Modified files: > usr.sbin/syslogd syslogd.c > Log: > Fix logging from remote hosts, which has been broken since (at least) revision > 1.64, i.e. July of last year. Also fix a minor style bug in the same code. > > PR: bin/28634 > Pointy hat to: dwmalone > Pointed out by: my buggy DSL router's remote logging facility > > Revision Changes Path > 1.88 +4 -3 src/usr.sbin/syslogd/syslogd.c -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message