From owner-svn-src-all@freebsd.org Tue May 10 16:05:25 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E576B35D5B; Tue, 10 May 2016 16:05:25 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f42.google.com (mail-oi0-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E275316A0; Tue, 10 May 2016 16:05:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f42.google.com with SMTP id x19so23126454oix.2; Tue, 10 May 2016 09:05:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=iPQ++Crd9XDq9iMrgFZBFMLIsCkbpVTWo0SBMmKjM5o=; b=TOm3fM5TknTBISPBdE+u2Av9zEeCqks0qS/rPCfxeJbYr7bBRfvLeAQFVhAr4cyrHY OLGCpsX9/8oqzQIH+s9HH7BHXl5+p11fMNNJSz6DVd4opTPCB/EjfER5ERqTX2lBblVl 4dxlAcVfy8GwSN+FbLW3sZhjO3q5W15FoU37L+fKnMuA7KQFtz4Zr91eZUOg2H51+7uj tfzjebvUGlwFX+BS/oFQrh4fKFCSYGcwSLWGhL+UWbAxP0I7+9cuIJKWtZHwn/VQn28h ebYCo/1eMU39V9uZI6Er5+zbDSohqpWTugGnKfI22INGW+VJ+sz6zqqkE9B09Vpyg0CF BF7Q== X-Gm-Message-State: AOPr4FUopHueS+M09yYTlupVewzzzvLa+qxjypjOn7Tap9isEpO3nCfiCQuL2ZpPBgGbPw== X-Received: by 10.202.218.84 with SMTP id r81mr4201685oig.49.1462896318271; Tue, 10 May 2016 09:05:18 -0700 (PDT) Received: from mail-oi0-f41.google.com (mail-oi0-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id j78sm740793oib.2.2016.05.10.09.05.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 May 2016 09:05:18 -0700 (PDT) Received: by mail-oi0-f41.google.com with SMTP id x19so23125969oix.2; Tue, 10 May 2016 09:05:17 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.157.36.135 with SMTP id z7mr2916246ota.69.1462896317766; Tue, 10 May 2016 09:05:17 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.6.111 with HTTP; Tue, 10 May 2016 09:05:17 -0700 (PDT) In-Reply-To: <4312956.Tckd6PoFKf@ralph.baldwin.cx> References: <201605101139.u4ABdaTL098171@repo.freebsd.org> <7693af09-def2-e8a7-b7fd-9b6df41908cc@selasky.org> <4312956.Tckd6PoFKf@ralph.baldwin.cx> Date: Tue, 10 May 2016 09:05:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r299363 - head/sys/compat/linuxkpi/common/include/asm From: Conrad Meyer To: John Baldwin Cc: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2016 16:05:25 -0000 On Tue, May 10, 2016 at 8:55 AM, John Baldwin wrote: > On Tuesday, May 10, 2016 05:06:08 PM Hans Petter Selasky wrote: >> On 05/10/16 13:39, Hans Petter Selasky wrote: >> > Author: hselasky >> > Date: Tue May 10 11:39:36 2016 >> > New Revision: 299363 >> > URL: https://svnweb.freebsd.org/changeset/base/299363 >> > >> > Log: >> > Use function macros when possible to avoid stray substitutions. >> > >> > MFC after: 1 week >> > Sponsored by: Mellanox Technologies >> > > > Is the reason for the change to avoid accepting the wrong number of arguments > (e.g. cpu_to_be32(x, y))? Won't that still fail to compile if so? (That is, > the reasoning for why you made the original change isn't clear to me from the > commit.) The macro form also prevents clobbering non-function-pointer variables named "cpu_to_be32," right? Not that that's a great variable name. Best, Conrad