From owner-svn-ports-head@FreeBSD.ORG  Wed Nov 28 16:08:25 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 1F3F879A; Wed, 28 Nov 2012 16:08:25 +0000 (UTC)
Date: Wed, 28 Nov 2012 16:08:25 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Alex Kozlov <ak@FreeBSD.org>
Subject: Re: svn commit: r307899 - head/benchmarks/super-smack
Message-ID: <20121128160825.GB53862@FreeBSD.org>
References: <201211281109.qASB9dPm010874@svn.freebsd.org>
 <20121128115359.GA53862@FreeBSD.org>
 <20121128130417.GA31569@ravenloft.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20121128130417.GA31569@ravenloft.kiev.ua>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2012 16:08:25 -0000

On Wed, Nov 28, 2012 at 03:04:17PM +0200, Alex Kozlov wrote:
> On Wed, Nov 28, 2012 at 11:53:59AM +0000, Alexey Dokuchaev wrote:
> > On Wed, Nov 28, 2012 at 11:09:39AM +0000, Alex Kozlov wrote:
> > > New Revision: 307899
> > > URL: http://svnweb.freebsd.org/changeset/ports/307899
> > > 
> > > +PGSQL_DESC=	Enable PostgreSQL support
> > > +MYSQL_DESC=	Enable MySQL support
> > > 
> > In this case, generic descriptions should have been used.
> > 
> No, specific descriptions are still better.

They are essentially the same modulo "enable" word, which was decided to
remove some time ago.  In fact, "generic" descriptions are better since they
mention that is it *database* support.  Doug removed the word "support" in
r305288, which many folks disagree with, but it will be backed out one we
will have dialog4ports committed, which will allow proper support for
checklists and radiobuttons.  You can leave them now, but after r305288 will
be backed out, I will ask you again to drop them.

> This was impossible to catch in vim, it should be automated like with WWW.
> If this tag is obsolete, then portlint should display a warning. I can
> implement the patch, but before that can you please point me to documentation
> where it stated? Thanks.

It is not technically obsolete; sometimes it is the only attribution we
can provide.  If there is actual WWW page, it should be dropped.

./danfe