From owner-freebsd-current@freebsd.org Fri Nov 6 22:33:20 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 78FF32D5400 for ; Fri, 6 Nov 2020 22:33:20 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CSZsr15mrz4tGr for ; Fri, 6 Nov 2020 22:33:20 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 25B702D505F; Fri, 6 Nov 2020 22:33:20 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 257D72D4CEC for ; Fri, 6 Nov 2020 22:33:20 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CSZsr0GBXz4svQ; Fri, 6 Nov 2020 22:33:19 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-qk1-f174.google.com with SMTP id 11so2618644qkd.5; Fri, 06 Nov 2020 14:33:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oM2TsfXspcHS6Wto3wOoX9N3YpsQQ2zxjh5NhmJqy50=; b=SfVhm+8iaS4yA1Hw6f7UeCrTdbV+xjtuJH1B4aV220bbqhcQ1/9jvoKDq3/2Tvl94i +xHuXeTrZ+ajdyOVOPEuzqEkuShxFx1nw6Wo3Qxn4v6q0s3znbPb5X+bSMnoTsiIHQRn ZrUg/e2Xx3jEyuQabwCC3yQ3hkJkM212Lxdtd/DNixvepHHCbWJUqCIyfr4qQgo0NRVs Dbq+wKs8GLIW+zNGbqsCoWoeMmK5oR9upNMvpm8/iFPu0tqbvnfHA1c30SEwsuixknLW 57XLrzzLugOAX04hZy9zvfxwxpKqjASEqVMqqr2BozLAM7hhNK3hQf2qWNHllUAo2yZE JD7Q== X-Gm-Message-State: AOAM5336jilLvytKyFvgbKQjsevzhWan+xQUEel4spcW3TxIXDCxQ8qt EamobjnOVLxXx1Beg+gf5i9QyPTDG4M= X-Google-Smtp-Source: ABdhPJxFLSOyqILz4gBABjaxxKtluXUIKXwShTgtFIXpTmW8W4DZTwTjTkKFg37z/pfuQyts8gWWoQ== X-Received: by 2002:a37:8b02:: with SMTP id n2mr3906659qkd.367.1604701998416; Fri, 06 Nov 2020 14:33:18 -0800 (PST) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id 189sm582432qki.59.2020.11.06.14.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2020 14:33:18 -0800 (PST) Received: by mail-yb1-f177.google.com with SMTP id c129so2485184yba.8; Fri, 06 Nov 2020 14:33:18 -0800 (PST) X-Received: by 2002:a25:2bc7:: with SMTP id r190mr6158494ybr.497.1604701997844; Fri, 06 Nov 2020 14:33:17 -0800 (PST) MIME-Version: 1.0 References: <88004d48-4434-875a-5a36-0627b00c2f38@gmail.com> <1906251966.36777.1590562439792.JavaMail.open-xchange@opme11oxm03aub.bagnolet.francetelecom.fr> <997c1389-5e18-b07e-d342-c787c841a4c4@gmail.com> <711876429.20200601003941@serebryakov.spb.ru> In-Reply-To: From: Eric Joyner Date: Fri, 6 Nov 2020 14:32:41 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM)) To: mike tancsa Cc: lev@freebsd.org, current X-Rspamd-Queue-Id: 4CSZsr0GBXz4svQ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 22:33:20 -0000 Could you reply to that issue with what you've found? Though, as far as I can recall, igb(4) devices are not supposed to do the iflib reset talked about in the bug, so I wouldn't expect to see a link flap on those. - Eric On Fri, Nov 6, 2020 at 12:48 PM mike tancsa wrote: > On 11/6/2020 2:17 PM, mike tancsa wrote: > > On 5/31/2020 5:39 PM, Lev Serebryakov wrote: > >> Hello Ian, > >> > >> Thursday, May 28, 2020, 2:45:48 AM, you wrote: > >> > >>> I noticed that my VLAN interfaces stopped working after a recent > build. > >>> tcpdump showed traffic leaving leaving and entering the interface but > no > >>> host on the network actually received any packets from this host. A > >>> binary search led me to r360902 and indeed the following change fixed > >>> the issue for me: > >> Problem is, this change will return terrible situation when adding new > VLAN > >> will flap connection status. > >> > >> It all worked before iflib: hardware VLAN filtering worked, and > >> adding/removing new VLAN didn't cause link to flap. > >> > >> Now, with iflib, looks like we can not have all good things at once :( > > > Looks like this is captured in > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240818 > > > > Hi All, > > > > Just came across this thread as I am running into this behaviour on > > RELENG_12. Adding a new vlan causes all vlans on the parent interface > > to flap. Not the greatest thing as it bounces a LOT of traffic > > potentially, flaps routing etc. Is there a way around this ? > > > > This is on r367411 releng12 > > > > igb0@pci0:2:0:0: class=0x020000 card=0x153315d9 chip=0x15338086 > > rev=0x03 hdr=0x00 > > vendor = 'Intel Corporation' > > device = 'I210 Gigabit Network Connection' > > class = network > > subclass = ethernet > > > > eg. just something simple like > > > > ifconfig vlan16 create 10.1.2.3/29 vlandev igb1 vlan 16 > > > > # dmesg | tail -8 > > igb1: link state changed to DOWN > > vlan16: link state changed to DOWN > > vlan2049: link state changed to DOWN > > vlan15: link state changed to DOWN > > igb1: link state changed to UP > > vlan16: link state changed to UP > > vlan2049: link state changed to UP > > vlan15: link state changed to UP > > > > > > ---Mike > > > > > > > > > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to " > freebsd-current-unsubscribe@freebsd.org" > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >