From owner-svn-src-all@freebsd.org Tue Feb 26 16:16:39 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8AACE151E0F9; Tue, 26 Feb 2019 16:16:39 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 18A038C412; Tue, 26 Feb 2019 16:16:39 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi1-x241.google.com with SMTP id q81so10779713oic.5; Tue, 26 Feb 2019 08:16:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AqNU/WQAqoW2czpUMzHfrv1msMtJwHBUrjE/5rbhPbk=; b=Du9IGLbnoDcm0Lib3G+3GRU4ZUpK7gcYmCW3py+no4A0n/yT3b1P3C2yMgw4SuUeYy 0m1yoo9/I4UlTmXgm3UAf3jxLG3OsaPiWUlYwzb6sHinIEB8LwDY33pLCwf1j75vZSlc nLNQ7tW6P/sxT3uMmwFGQZCviFW8divbMyKiq58PGbn81o3kL1IM0rWKUkYpNOxvkCH5 BdT3c/Xen1QH8ddzCHLFZ2WGqP3IfAJ8Xct+6okvtM4vHsrYOUyvPXiw+XFzfjVgGmxo JSk81FqVGL5OXDMHDnvym2Qp7oGKfBtClhn4LPk+BGBPp8VjtKVDQXZcgWuHTIHYga+o Lztg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AqNU/WQAqoW2czpUMzHfrv1msMtJwHBUrjE/5rbhPbk=; b=L43I1Fm2EczfnWbB/znt1E+GAoNdH+Mvd1K+g2l4NIXd6UJmwIRRc4wj6XG2F6jrWu oFv2mcB/jona8sKpr6KKFGwPKIEnjYdSrB0S7CbNairloVpn8DkLTuzyGigxRfD8HU/g z/BlSKXuAsiI3WSkg7uSMfO5x4lUhRSHMd2Fiu15xBjeZFBvC7MsWJkPkbeivhe2XqWy 40y79Qv+KbNcOpwFXer2LYbfATk8rx+zYFIiQnfBIpVe4fCiUMY6dgsA4+2TpmMg0X06 xGg9iLyb/i6fOFflGC1Jr77+bRuMz3pTxafIySbW4qXoJW94pU7N9OILSxBSLnDST2jN GWHg== X-Gm-Message-State: AHQUAubyJP3nXkvVrc3gR9SnSyPEgTk3Dltq9XG9EzUqr8rDJdXHzyeU AMLwQQi9JskxSCBmNYqkFjKtaIW9bFtRPO+Ox/c= X-Google-Smtp-Source: AHgI3IbRRUL4kz8+1sgnlmMpq/Shbhw4dstSPiClZiso93rN+lzlV5DWA9K85BPz34AHwEcS7Lxt2Tdo5u6hGMMJ1jc= X-Received: by 2002:aca:54c5:: with SMTP id i188mr2929583oib.16.1551197798356; Tue, 26 Feb 2019 08:16:38 -0800 (PST) MIME-Version: 1.0 References: <201902260818.x1Q8IZGO061175@repo.freebsd.org> <39F76FF0-B40A-43F9-AC77-5D535674A4B8@cschubert.com> <1F5FB340-1CD2-400F-82D3-8D4949A351A2@cschubert.com> In-Reply-To: <1F5FB340-1CD2-400F-82D3-8D4949A351A2@cschubert.com> From: Benjamin Kaduk Date: Tue, 26 Feb 2019 10:16:27 -0600 Message-ID: Subject: Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common To: Cy Schubert Cc: Baptiste Daroussin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 18A038C412 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 16:16:39 -0000 On Tue, Feb 26, 2019 at 10:14 AM Cy Schubert wrote: > On February 26, 2019 7:48:27 AM PST, Cy Schubert < > Cy.Schubert@cschubert.com> wrote: > >On February 26, 2019 12:18:35 AM PST, Baptiste Daroussin > > wrote: > [trimming the unneeded pile of commit body] > >This broke my systems, many filesystems fail to mount causing nullfs > >late mounts to fail. No details now until tonight. > > > >Suggest we back this out until it is properly tested. > > Nested zfs filesystems seem not to be handled properly or possibly not > supported any more. This explains my mail gateway also not mounting all > filesystems in /home. It was odd that dovecot stopped working. > > The symptom of the problem is zfs mount -a no longer mounts all > filesystems. Zfs mount fails saying the filesystem is already mounted. The > workaround is to zfs umount each affected zfs dataset by hand and zfs mount > it by hand. > > Generally this has screwed up sites that have hundreds (in my case 122) > zfs datasets. The work around might be to script testing each mount, > unmounting and remounting if necessary. > > I'm being sarcastic about creating an rc script to clean this up. This > needs to be backed out and tested properly before being committed. > > I don't know what you mean by "nested zfs filesystems" -- do you mean a zpool within a zvol? That has been unsupported for a long time, IIRC. And I'm not sure what else "nested filesystems" would be, since having (e.g.) separate zfs filesystems for /usr and /usr/ports is so common that surely it has already been tested... -Ben