From owner-svn-ports-all@FreeBSD.ORG  Tue Dec  4 18:09:53 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 664)
 id B301449A; Tue,  4 Dec 2012 18:09:53 +0000 (UTC)
Date: Tue, 4 Dec 2012 10:09:53 -0800
From: David O'Brien <obrien@FreeBSD.org>
To: Eitan Adler <eadler@freebsd.org>
Subject: Re: svn commit: r308256 - in head/misc/figlet: . files
Message-ID: <20121204180953.GJ3960@dragon.NUXI.org>
References: <201212041734.qB4HYC4A045663@svn.freebsd.org>
 <CAF6rxg=_MRSQr7Us1J5NeGd=8C8s6U09Xoy9ARw0g6N0yejL9Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAF6rxg=_MRSQr7Us1J5NeGd=8C8s6U09Xoy9ARw0g6N0yejL9Q@mail.gmail.com>
X-Operating-System: FreeBSD 10.0-CURRENT
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger?
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: obrien@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2012 18:09:53 -0000

On Tue, Dec 04, 2012 at 12:44:04PM -0500, Eitan Adler wrote:
> On 4 December 2012 12:34, David E. O'Brien <obrien@freebsd.org> wrote:
> > Author: obrien
> > Date: Tue Dec  4 17:34:12 2012
> > New Revision: 308256
> > URL: http://svnweb.freebsd.org/changeset/ports/308256
> >
> > Log:
> >   Run the tests to ensure a good build.
> 
> Other ports use test: or regression-test: for this. Can we use the same?

I want the always tests to run so we know if we have a bad build.
I would think we should always do this as otherwise the tests will likely
seldom get run.

I could change it to:

    -post-build:
    +regression-test:
	    @ cd ${WRKSRC} && ${MAKE} check
     
    +post-build test: regression-test

so that these targets exist for manual running.  I actually like that, so
I'll commit this patch and we can continue talking about the 'post-build'
usage.

-- 
-- David  (obrien@FreeBSD.org)