From owner-freebsd-geom@freebsd.org Sun Jul 24 08:23:27 2016 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D265BA3D61 for ; Sun, 24 Jul 2016 08:23:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0418714F4 for ; Sun, 24 Jul 2016 08:23:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6O8NPMo021835 for ; Sun, 24 Jul 2016 08:23:26 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 211028] [GEOM][Hyper-V] gpart can't detect the new free space after the disk capacity changes Date: Sun, 24 Jul 2016 08:23:26 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ae@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jul 2016 08:23:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211028 --- Comment #27 from Andrey V. Elsukov --- (In reply to Peter Wemm from comment #26) > On closer examination, the GPT headers on these drives have strange things > going on. It does look like there's a 6 sector overallocation: > GEOM_PART: da1 was automatically resized. > Use `gpart commit da1` to save changes or `gpart undo da1` to revert th= em. > GEOM_PART: partition 3 has end offset beyond last LBA: 143374615 > 143374= 610 > GEOM_PART: integrity check failed (da1, GPT) >=20 > However.. I am puzzled as to why this is only sometimes detected. As I > said in #24 above, sometimes the machine boots fine without a peep. All 6 > drives in the machine in question are in this state. My guess is the following, it looks like disk reported that its size decrea= sed. This leads to resize and integrity check in geom_part. Since integrity check has been failed, geom is going to be withered. In the meantime disk reported again about changed size, this event handled before geom has fully destroye= d, but its softc now will be NULL, so this leads to panic what you see. Probab= ly the following patch will fix this panic, but I'm not sure that there will n= ot another panic due to disappeared GPT. Index: geom_subr.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- geom_subr.c (revision 303255) +++ geom_subr.c (working copy) @@ -636,7 +636,7 @@ g_resize_provider_event(void *arg, int flag) LIST_FOREACH_SAFE(cp, &pp->consumers, consumers, cp2) { gp =3D cp->geom; - if (gp->resize !=3D NULL) + if ((gp->flags & G_GEOM_WITHER) =3D=3D 0 && gp->resize !=3D= NULL) gp->resize(cp); } --=20 You are receiving this mail because: You are on the CC list for the bug.=