From owner-svn-src-all@FreeBSD.ORG Sat Jul 2 22:25:25 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99E68106566B; Sat, 2 Jul 2011 22:25:25 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail17.syd.optusnet.com.au (mail17.syd.optusnet.com.au [211.29.132.198]) by mx1.freebsd.org (Postfix) with ESMTP id 27A318FC17; Sat, 2 Jul 2011 22:25:24 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c220-239-116-103.belrs4.nsw.optusnet.com.au [220.239.116.103]) by mail17.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p62MPMTT014200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 3 Jul 2011 08:25:23 +1000 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.4/8.14.4) with ESMTP id p62MPL1j001396; Sun, 3 Jul 2011 08:25:21 +1000 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.4/8.14.4/Submit) id p62MPKP8001395; Sun, 3 Jul 2011 08:25:20 +1000 (EST) (envelope-from peter) Date: Sun, 3 Jul 2011 08:25:20 +1000 From: Peter Jeremy To: Ben Kaduk Message-ID: <20110702222520.GA28815@server.vk2pj.dyndns.org> References: <201107021354.p62DsKnm042696@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9" Content-Disposition: inline In-Reply-To: X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Schouten Subject: Re: svn commit: r223722 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jul 2011 22:25:25 -0000 --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011-Jul-02 11:13:57 -0400, Ben Kaduk wrote: >On Sat, Jul 2, 2011 at 9:54 AM, Ed Schouten wrote: >> =A0Reintroduce the cioctl() hook in the TTY layer for digi(4). Thanks Ed. >> =A0The cioctl() hook can be used by drivers to add ioctls to the *.init = and >> =A0*.lock devices. This commit breaks the ttydevsw ABI, since this > >Aren't __FreeBSD_version bumps cheap, these days? A __FreeBSD_version bump can help a driver determine whether specific functionality is available in the kernel but that doesn't solve this particular issue. A struct ttydevsw is allocated and populated by a TTY device driver and passed to the generic TTY code to define callbacks from the generic code into the driver. Consider the case where a module compiled with an old struct ttydevsw definition is loaded into a new kernel - the generic TTY code will attempt to reference ttydevsw fields that aren't defined by the driver, with results that won't be pretty. --=20 Peter Jeremy --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iEYEARECAAYFAk4PmtAACgkQ/opHv/APuIeX8QCfZHpQ6DnaY55zRfjddq/S3sRw mW4An23PaaPTgA1ZIx393g78U+BQVYEv =ZXJy -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9--