From nobody Thu Feb 19 17:16:32 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fH0R5266Sz6S6tK for ; Thu, 19 Feb 2026 17:16:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fH0R46cWfz3FQ8 for ; Thu, 19 Feb 2026 17:16:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771521393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GWgM/gvImpstJk6hZOKA79d5SvJNPOVFnFsXwzDICVI=; b=I6PAMtWG6MeRSsrN0wmdvHJebjewpKD0TJe5wHHLmEfrkffoBGY5a1A4FVVNrTow+X21K2 A33SQjrtJGOS8Z4a0dbOwzDbxc6aZmck0pZj3HxAqXkKJ0XDJMXu1K8Z+DEAV7SGmw8lY1 WzAyDpTR28oAYP9kF/QQ+yV6E4hPOKtGAyRbo8CtkUaBIXZFmpZUCwdwkAOrTic0KZPELm wmPTcrVmdVKIRb8lYfpo7G3+GHP6v+z3U32ikpEgLT4Rsbgj+PlF8w6UU0Wgxyx0QQDbxO IF+lRzQsOYiMhIFyqRIhnBZKtykdGF82vHdz7WJcCCWaQEEYp2w2yLmJ6k0N3w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771521393; a=rsa-sha256; cv=none; b=GtMhOqesMzDweiQB0UaM1CqXSovVKjKQ4aCw6k4fnMD+glg1gU0bgV412TJVUnJqXcrtYb OCYhOmq1VpJ+GC6JQFJr+oSqk7APaFiucjrwKz5rKyy1qxJQEuIFeddlUcA0XJ+R1X6sQB GelYrPhMonIP76gIYSy796ADHnZBbtheDb9B8WrzXM1HH7mDwX86HoYNm7MK71v37sKTiF snmLLo4ovU7i8W2qG9bRt5E4y7bn5GFssz0fFjWVnvrBxDHuyC8y6B+j44esuvV8Aefu4T QejgYC+2Ts3PvYl0Twna5KgjJH1IFsVVs2wJDY/J748Y4z88Ds3Cwr8VQH6ryg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771521393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GWgM/gvImpstJk6hZOKA79d5SvJNPOVFnFsXwzDICVI=; b=S4tn3n5n7JeFKd7sHeh9Iq6JwraehbW65gfQS6h/W4xXrHQtj/m72WGAiejS+HPonmE6y/ IKlORemRVfYaGhfakqMGf68yt62r5oH1lH265ng1wRsjF0osaONyD4JheVb/M5mrXzWnki K3aeyajt4RZvM1VKHZEzACfCmLK2+XdQpgxA8lHv0dNbjQxkeV9UYqjbQx1pPMCx3A+CRS LeiMXboa3yYPXTW+mPTojrElK4UnipOWONp51VApBwSUvvo1GxfacaH/1U3zx8+qzG4Au8 lo9SMxpSgJ+oskwI1ttCB2AwMY6ndIHk+XLiyxP/pQX39Lsean8dPO2jwQqQlg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fH0R468LfzrPG for ; Thu, 19 Feb 2026 17:16:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39412 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Feb 2026 17:16:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: bc7862bc916c - main - vmm: Start using exterror List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bc7862bc916c3b81bcdc374e5144ab2f5bf62b19 Auto-Submitted: auto-generated Date: Thu, 19 Feb 2026 17:16:32 +0000 Message-Id: <69974570.39412.15c313da@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=bc7862bc916c3b81bcdc374e5144ab2f5bf62b19 commit bc7862bc916c3b81bcdc374e5144ab2f5bf62b19 Author: Mark Johnston AuthorDate: 2026-02-19 14:39:12 +0000 Commit: Mark Johnston CommitDate: 2026-02-19 17:16:15 +0000 vmm: Start using exterror For now, just describe the error where an unprivileged user attempts to run a VM without DESTROY_ON_CLOSE semantics, i.e., monitor mode. Reviewed by: bnovkov MFC after: 2 months Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D54743 --- lib/libc/gen/exterr_cat_filenames.h | 1 + sys/dev/vmm/vmm_dev.c | 5 ++++- sys/sys/exterr_cat.h | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/libc/gen/exterr_cat_filenames.h b/lib/libc/gen/exterr_cat_filenames.h index d55396a1b286..e45d05e384bd 100644 --- a/lib/libc/gen/exterr_cat_filenames.h +++ b/lib/libc/gen/exterr_cat_filenames.h @@ -2,6 +2,7 @@ * Automatically @generated, use * tools/build/make_libc_exterr_cat_filenames.sh */ + [EXTERR_CAT_VMM] = "dev/vmm/vmm_dev.c", [EXTERR_CAT_FUSE_DEVICE] = "fs/fuse/fuse_device.c", [EXTERR_CAT_FUSE_VFS] = "fs/fuse/fuse_vfsops.c", [EXTERR_CAT_FUSE_VNOPS] = "fs/fuse/fuse_vnops.c", diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 0e5477745db5..ed8e5b2e0777 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -8,6 +8,8 @@ #include #include +#define EXTERR_CATEGORY EXTERR_CAT_VMM +#include #include #include #include @@ -1010,7 +1012,8 @@ vmmdev_create(const char *name, uint32_t flags, struct ucred *cred) if ((flags & VMMCTL_CREATE_DESTROY_ON_CLOSE) == 0 && (error = priv_check_cred(cred, PRIV_VMM_CREATE)) != 0) { sx_xunlock(&vmmdev_mtx); - return (error); + return (EXTERROR(error, + "An unprivileged user must run VMs in monitor mode")); } if (!chgvmmcnt(cred->cr_ruidinfo, 1, vm_maxvmms)) { diff --git a/sys/sys/exterr_cat.h b/sys/sys/exterr_cat.h index 015eb6a1ae76..4f3ff6925242 100644 --- a/sys/sys/exterr_cat.h +++ b/sys/sys/exterr_cat.h @@ -39,6 +39,7 @@ #define EXTERR_CAT_FUSE_DEVICE 14 #define EXTERR_CAT_FORK 15 #define EXTERR_CAT_PROCEXIT 16 +#define EXTERR_CAT_VMM 17 #endif