Date: Tue, 21 Feb 2006 10:05:25 +0000 (GMT) From: Neil Darlow <neil@darlow.co.uk> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/93633: clamsmtp-1.6_2 rcscript still broken Message-ID: <20060221100525.A2FB34AC26@router.darlow.co.uk> Resent-Message-ID: <200602211010.k1LAA2aL072522@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 93633
>Category: ports
>Synopsis: clamsmtp-1.6_2 rcscript still broken
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Feb 21 10:10:02 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Neil Darlow
>Release: FreeBSD 6.0-RELEASE-p4 i386
>Organization:
>Environment:
System: FreeBSD router.darlow.co.uk 6.0-RELEASE-p4 FreeBSD 6.0-RELEASE-p4 #0: Fri Feb 10 16:26:47 GMT 2006 root@router.darlow.co.uk:/usr/obj/usr/src/sys/ROUTER i386
>Description:
The fixes to clamsmtpd.sh in clamsmtp-1.6_2 are insufficient. The -f and -p
arguments aren't set correctly because command_args is set too early in the
script.
>How-To-Repeat:
Attempt to start clamsmtpd.
>Fix:
The following patch has been applied and tested to verify correct startup of
clamsmtpd:
--- clamsmtpd.sh.in.orig Tue Feb 21 07:24:21 2006
+++ clamsmtpd.sh.in Tue Feb 21 09:52:10 2006
@@ -20,9 +20,6 @@
rcvar=${name}_enable
command=%%PREFIX%%/sbin/${name}
-command_args="-f ${clamsmtpd_conf} -p ${clamsmtpd_pid}"
-required_files=${clamsmtpd_conf}
-pidfile=${clamsmtpd_pid}
sig_stop=-KILL
load_rc_config ${name}
@@ -30,5 +27,9 @@
: ${clamsmtpd_enable="NO"}
: ${clamsmtpd_conf="%%PREFIX%%/etc/clamsmtpd.conf"}
: ${clamsmtpd_pid="%%CLAMAV_PID_DIR%%/clamsmtpd.pid"}
+
+command_args="-f ${clamsmtpd_conf} -p ${clamsmtpd_pid}"
+required_files=${clamsmtpd_conf}
+pidfile=${clamsmtpd_pid}
run_rc_command "$1"
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060221100525.A2FB34AC26>