Date: Sun, 12 Nov 2017 08:03:19 +0000 From: Brooks Davis <brooks@freebsd.org> To: Alexey Dokuchaev <danfe@nsu.ru> Cc: ports@freebsd.org Subject: Re: RTTI support in devel/llvm40 (and maybe other llvm ports) Message-ID: <20171112080319.GB76223@spindle.one-eyed-alien.net> In-Reply-To: <20171110070748.GA27570@regency.nsu.ru> References: <20171110070748.GA27570@regency.nsu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--IiVenqGWf+H9Y6IX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 10, 2017 at 02:07:48PM +0700, Alexey Dokuchaev wrote: > Hi Brooks, >=20 > I've just found out that our `devel/llvm40' port comes without > -DLLVM_ENABLE_RTTI=3DON on the CMAKE_ARGS. This is a regression > from e.g. 3.4 times when it was enabled by default. >=20 > The problem is that RTTI support is required by some consumers, > e.g. `graphics/openshadinglanguage' and `graphics/appleseed' > (cf. https://github.com/appleseedhq/appleseed/issues/1625), > but I cannot enable RTTI in those ports unless I enable it in > LLVM port(s) first. >=20 > The patch is very simple (apart port revision bump): >=20 > @@ -39,7 +41,7 @@ > SUB_LIST=3D LLVM_PREFIX=3D"${LLVM_PREFIX}" LLVM_SUFFIX=3D"${LLVM_SUFFIX}" > CMAKE_INSTALL_PREFIX=3D ${LLVM_PREFIX} > -CMAKE_ARGS=3D -DLLVM_BUILD_LLVM_DYLIB=3DON > +CMAKE_ARGS=3D -DLLVM_BUILD_LLVM_DYLIB=3DON -DLLVM_ENABLE_RTTI=3DON >=20 > Could you review/commit it, and check if other LLVM ports could > also benefit from it? Thanks, It's been a few years since we disabled it so I don't remember the details of the decision. I'll look into it, but am not in a position to test for breakage to other ports. IIRC there were once ports that failed to build both with and without so it may be that we need to wait for flavors to make this change. -- Brooks --IiVenqGWf+H9Y6IX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJaCABGAAoJEKzQXbSebgfAqSYH/00qnqa2J1YzJfFYcwvHo+8L /NPizytixbCm0uyRec1flN0CCK/q3BiMd2Pub4U9NW9KiQaysD+H6ZywxwhfAteG qlj4DBB2sdn4ImY4WWk2bgJSEUr0exUdyYCUmgRG3JjKRelpuAG/waERvpe1aGat lDK/hc0C1eb5HI7RIw8rItRcYwmH8gf7DWs1w65oKa7ZTtSoBCiMxBvqdU4h3had SI2Md1RGypSEIDTSovxwtIZhGCgo1daCM3SJ26OiNEzO1CWsPkDwVzV1dTg9rxEM 9gOzZHeluIrlGrvOyQrI5nB3+/nwHH5Srp1eU2eybMkqYiB0EfSa+IMQub+0ZWA= =u0kH -----END PGP SIGNATURE----- --IiVenqGWf+H9Y6IX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171112080319.GB76223>