From owner-cvs-sys Wed Feb 4 12:41:07 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id MAA05559 for cvs-sys-outgoing; Wed, 4 Feb 1998 12:41:07 -0800 (PST) (envelope-from owner-cvs-sys) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA05473; Wed, 4 Feb 1998 12:40:45 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id MAA23259; Wed, 4 Feb 1998 12:33:16 -0800 (PST) Received: from UNKNOWN(), claiming to be "current1.whistle.com" via SMTP by alpo.whistle.com, id smtpd023257; Wed Feb 4 12:33:14 1998 Message-ID: <34D8CFB1.ABD322C@whistle.com> Date: Wed, 04 Feb 1998 12:29:37 -0800 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2.5-RELEASE i386) MIME-Version: 1.0 To: Eivind Eklund CC: Bruce Evans , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, eivind@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci brktree_reg.h brooktree848.c References: <199802040748.SAA00670@godzilla.zeta.org.au> <34D8BA73.59E2B600@whistle.com> <19980204211555.00395@follo.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Eivind Eklund wrote: > > On Wed, Feb 04, 1998 at 10:58:59AM -0800, Julian Elischer wrote: > [on saving DEVFS tokens, which is only required for LKMable devices] > > hopefully ALL drivers will eventually be loadable.. > > saving the token now is just to save having to do it later.. > > I disagree. Saving the token now is creating dead code, which you > _might_ want to have similar code to later. And this tends to create > dependencies on the DEVFS option in header files, which is evil. > > I don't think we'll have loadable modules for most of the drivers > until at the _very_ least 1/2 yeaqr into the future, and by then we'll > hopefully have DEVFS as a default and get rid of the option :-) > > Eivind. in all the drivers I modified (that's nearly all of them) I ifdef'd the tokens so they are not causing bloat.. julian