From owner-svn-ports-head@freebsd.org Tue Apr 5 21:44:42 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73A94B04462; Tue, 5 Apr 2016 21:44:42 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 3EFAB1502; Tue, 5 Apr 2016 21:44:41 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 1EE1CBDC85; Tue, 5 Apr 2016 23:44:39 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id F1727BDC7A; Tue, 5 Apr 2016 23:44:38 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id B8878586C059; Tue, 5 Apr 2016 23:44:38 +0200 (CEST) Date: Tue, 05 Apr 2016 23:44:38 +0200 From: Mathieu Arnold To: Kurt Jaeger , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r412586 - in head/net-mgmt: zabbix3-agent zabbix3-proxy zabbix3-server Message-ID: In-Reply-To: <201604052013.u35KDoSE034263@repo.freebsd.org> References: <201604052013.u35KDoSE034263@repo.freebsd.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="==========D7DA3D65A75E2AD95DF1==========" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2016 21:44:42 -0000 --==========D7DA3D65A75E2AD95DF1========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline +--On 5 avril 2016 20:13:50 +0000 Kurt Jaeger wrote: | +.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000 | +WITH_OPENSSL_PORT=yes | +.endif This is a bad idea, WITH_OPENSSL_PORT is a global directive. After installing this, some ports will use the base openssl, and some will use the ports one. I know other ports do it, it still is a bad idea. It would be much better to do something like this: .if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000 && !defined(WITH_OPENSSL_PORT) IGNORE= OpenSSL from the base system is too old, add WITH_OPENSSL_PORT to your /etc/make.conf and rebuild everything that needs SSL. .endif Or something similar. -- Mathieu Arnold --==========D7DA3D65A75E2AD95DF1========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJXBDHGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IbXQP/21kWxH3ZCuKqfZ8+95w4xM2 S2j6Ncib+AkgKf7CRPfct6Ej0+5kXrq5oIp/SlZ6y1OrxYtn0DsMJ2d/pR5fOo/w waQZESTy/JgCajpS2vfo3qS0emUX/m+ArVrIvjEH463/R9lhGBtV12CpmSFksG7R geWswgGHy/CBkkKTIhEk9BiqJQGQfFHSiy6CBTzHP6YJ7c4DRfSc6FhE/IF6QI1v 9KlaqtH9Z+QlVGJXth0ifnq9mjdxT2of1I3aRgnYCe2VUYB2iTRVnPL33qa6Oz9z hKmxbYR3+DP4qjWRGNXvrzw5FmxXwAHjg4o24r7em8tRAJs/pkkPNf+1MCuwuEuq IHEH1Qvajq78gStT2+rkmecBMJDQ3dV/HaA9TPYoWR92+ZTaFNpRIIihOEq9UZCb BZceTiM5S92TaGKGq4ioOF81YYeyVjmnO5gRW4+/6n6pE8Tm6X2lh9URotQ/3eYH st2+/UVXBISRhH6EDGqKe3x9RUwuRJ6WKQWfzczqGN7KT+XcYLxbZcfvDteu9/O1 u5K0LST9WptGBc0slxyTjQb/fH6N8WBRlhRTf1hZjzVuV7FaODCjd4tfjJdw0h6i FAKkf6AmOx7+v2jWzCfegGnJ4PZFEAXIQqhHZBED2vOJBos5qsLssJHcQYgXdaKK U0fN1UYsa9DlmCMkey/x =ExcB -----END PGP SIGNATURE----- --==========D7DA3D65A75E2AD95DF1==========--